This is an automated email from the ASF dual-hosted git repository. liujun pushed a commit to branch dev-metadata in repository https://gitbox.apache.org/repos/asf/incubator-dubbo.git
commit 740b5aae832828d16e7bdeb871f430fb0810bb1c Author: ken.lj <[email protected]> AuthorDate: Wed Nov 21 10:25:03 2018 +0800 remove unnecessary volatile restrict --- .../java/org/apache/dubbo/common/config/Environment.java | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/dubbo-common/src/main/java/org/apache/dubbo/common/config/Environment.java b/dubbo-common/src/main/java/org/apache/dubbo/common/config/Environment.java index 0e77565..efc77d6 100644 --- a/dubbo-common/src/main/java/org/apache/dubbo/common/config/Environment.java +++ b/dubbo-common/src/main/java/org/apache/dubbo/common/config/Environment.java @@ -29,14 +29,14 @@ import java.util.concurrent.ConcurrentHashMap; public class Environment { private static final Environment INSTANCE = new Environment(); - private volatile Map<String, PropertiesConfiguration> propertiesConfsHolder = new ConcurrentHashMap<>(); - private volatile Map<String, SystemConfiguration> systemConfsHolder = new ConcurrentHashMap<>(); - private volatile Map<String, EnvironmentConfiguration> environmentConfsHolder = new ConcurrentHashMap<>(); - private volatile Map<String, InmemoryConfiguration> externalConfsHolder = new ConcurrentHashMap<>(); - private volatile Map<String, InmemoryConfiguration> appExternalConfsHolder = new ConcurrentHashMap<>(); - private volatile Map<String, CompositeConfiguration> startupCompositeConfsHolder = new ConcurrentHashMap<>(); - - private volatile boolean isConfigCenterFirst = true; + private Map<String, PropertiesConfiguration> propertiesConfsHolder = new ConcurrentHashMap<>(); + private Map<String, SystemConfiguration> systemConfsHolder = new ConcurrentHashMap<>(); + private Map<String, EnvironmentConfiguration> environmentConfsHolder = new ConcurrentHashMap<>(); + private Map<String, InmemoryConfiguration> externalConfsHolder = new ConcurrentHashMap<>(); + private Map<String, InmemoryConfiguration> appExternalConfsHolder = new ConcurrentHashMap<>(); + private Map<String, CompositeConfiguration> startupCompositeConfsHolder = new ConcurrentHashMap<>(); + + private boolean isConfigCenterFirst = true; private Map<String, String> externalConfigurationMap = new HashMap<>(); private Map<String, String> appExternalConfigurationMap = new HashMap<>();
