[incubator-dubbo] branch master updated: Enhance unit test (#2920)

[huxing]

This is an automated email from the ASF dual-hosted git repository.

huxing pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-dubbo.git


The following commit(s) were added to refs/heads/master by this push:
     new 107a0cc  Enhance unit test (#2920)
107a0cc is described below

commit 107a0cc11ac8fa38986025bb7adec700d5c65482
Author: XiaoJie Li <lixiaojie_...@outlook.com>
AuthorDate: Sat Dec 8 21:43:27 2018 +0800

    Enhance unit test (#2920)
---
 .../registry/dubbo/RegistryDirectoryTest.java      | 33 +++++++++++++++++++++-
 1 file changed, 32 insertions(+), 1 deletion(-)

diff --git 
a/dubbo-registry/dubbo-registry-default/src/test/java/org/apache/dubbo/registry/dubbo/RegistryDirectoryTest.java
 
b/dubbo-registry/dubbo-registry-default/src/test/java/org/apache/dubbo/registry/dubbo/RegistryDirectoryTest.java
index 95459b2..8c8b8ea 100644
--- 
a/dubbo-registry/dubbo-registry-default/src/test/java/org/apache/dubbo/registry/dubbo/RegistryDirectoryTest.java
+++ 
b/dubbo-registry/dubbo-registry-default/src/test/java/org/apache/dubbo/registry/dubbo/RegistryDirectoryTest.java
@@ -34,7 +34,7 @@ import 
org.apache.dubbo.rpc.cluster.loadbalance.LeastActiveLoadBalance;
 import org.apache.dubbo.rpc.cluster.loadbalance.RoundRobinLoadBalance;
 import org.apache.dubbo.rpc.cluster.router.script.ScriptRouter;
 import org.apache.dubbo.rpc.cluster.router.script.ScriptRouterFactory;
-
+import org.apache.dubbo.rpc.cluster.support.wrapper.MockClusterInvoker;
 import org.junit.Assert;
 import org.junit.Before;
 import org.junit.Test;
@@ -1014,6 +1014,37 @@ public class RegistryDirectoryTest {
         List<Invoker<DemoService>> invokers = 
registryDirectory.list(invocation);
         Assert.assertEquals(2, invokers.size());
     }
+    
+    @Test
+    public void test_Notified_withGroupFilter() {
+       URL directoryUrl = 
noMeaningUrl.addParameterAndEncoded(Constants.REFER_KEY, "interface" + service 
+ "&group=group1,group2");
+       RegistryDirectory directory = this.getRegistryDirectory(directoryUrl);
+       URL provider1 = 
URL.valueOf("dubbo://10.134.108.1:20880?methods=getXXX&group=group1&mock=false");
+       URL provider2 = 
URL.valueOf("dubbo://10.134.108.1:20880?methods=getXXX&group=group2&mock=false");
+       
+       List<URL> providers = new ArrayList<>();
+       providers.add(provider1);
+       providers.add(provider2);
+       directory.notify(providers); 
+       
+       invocation = new RpcInvocation();
+       invocation.setMethodName("getXXX");
+       List<Invoker<DemoService>> invokers = directory.list(invocation);
+       
+       Assert.assertEquals(2, invokers.size());
+       Assert.assertTrue(invokers.get(0) instanceof MockClusterInvoker);
+       Assert.assertTrue(invokers.get(1) instanceof MockClusterInvoker);
+       
+       directoryUrl = noMeaningUrl.addParameterAndEncoded(Constants.REFER_KEY, 
"interface" + service + "&group=group1");
+       directory = this.getRegistryDirectory(directoryUrl);
+       directory.notify(providers);
+       
+       invokers = directory.list(invocation);
+       
+       Assert.assertEquals(2, invokers.size());
+       Assert.assertFalse(invokers.get(0) instanceof MockClusterInvoker);
+       Assert.assertFalse(invokers.get(1) instanceof MockClusterInvoker);
+    }
 
     enum Param {
         MORGAN,