This is an automated email from the ASF dual-hosted git repository.
iluo pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-dubbo.git
The following commit(s) were added to refs/heads/master by this push:
new f5be817 should not skipTests (#2958)
f5be817 is described below
commit f5be817c0077c85c0d9ecc0026d0fd396684a03a
Author: zhaixiaoxiang <xxz...@126.com>
AuthorDate: Fri Dec 14 11:52:02 2018 +0800
should not skipTests (#2958)
---
PULL_REQUEST_TEMPLATE.md | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/PULL_REQUEST_TEMPLATE.md b/PULL_REQUEST_TEMPLATE.md
index 5427bec..8cb19f9 100644
--- a/PULL_REQUEST_TEMPLATE.md
+++ b/PULL_REQUEST_TEMPLATE.md
@@ -16,5 +16,5 @@ Follow this checklist to help us incorporate your
contribution quickly and easil
- [ ] Format the pull request title like `[Dubbo-XXX] Fix UnknownException
when host config not exist #XXX`. Each commit in the pull request should have a
meaningful subject line and body.
- [ ] Write a pull request description that is detailed enough to understand
what the pull request does, how, and why.
- [ ] Write necessary unit-test to verify your logic correction, more mock a
little better when cross module dependency exist. If the new feature or
significant change is committed, please remember to add integration-test in
[test module](https://github.com/apache/incubator-dubbo/tree/master/dubbo-test).
-- [ ] Run `mvn clean install -DskipTests` & `mvn clean test-compile
failsafe:integration-test` to make sure unit-test and integration-test pass.
+- [ ] Run `mvn clean install -DskipTests=false` & `mvn clean test-compile
failsafe:integration-test` to make sure unit-test and integration-test pass.
- [ ] If this contribution is large, please follow the [Software Donation
Guide](https://github.com/apache/incubator-dubbo/wiki/Software-donation-guide).
