[incubator-dubbo] branch master updated: simply telnet command enabled check logic (#3316)

[carryxyh]

This is an automated email from the ASF dual-hosted git repository.

carryxyh pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-dubbo.git


The following commit(s) were added to refs/heads/master by this push:
     new babf0d1  simply telnet command enabled check logic (#3316)
babf0d1 is described below

commit babf0d13b67a721a73247cba0919157fd04491ef
Author: kexianjun <kexianjun1...@hotmail.com>
AuthorDate: Wed Jan 23 17:27:51 2019 +0800

    simply telnet command enabled check logic (#3316)
    
    * simply telnet command enabled check
---
 .../remoting/telnet/support/TelnetHandlerAdapter.java   | 17 +++++++----------
 1 file changed, 7 insertions(+), 10 deletions(-)

diff --git 
a/dubbo-remoting/dubbo-remoting-api/src/main/java/org/apache/dubbo/remoting/telnet/support/TelnetHandlerAdapter.java
 
b/dubbo-remoting/dubbo-remoting-api/src/main/java/org/apache/dubbo/remoting/telnet/support/TelnetHandlerAdapter.java
index f740b3d..66418f3 100644
--- 
a/dubbo-remoting/dubbo-remoting-api/src/main/java/org/apache/dubbo/remoting/telnet/support/TelnetHandlerAdapter.java
+++ 
b/dubbo-remoting/dubbo-remoting-api/src/main/java/org/apache/dubbo/remoting/telnet/support/TelnetHandlerAdapter.java
@@ -81,20 +81,17 @@ public class TelnetHandlerAdapter extends 
ChannelHandlerAdapter implements Telne
     }
 
     private boolean commandEnabled(URL url, String command) {
-        boolean commandEnable = false;
         String supportCommands = url.getParameter(Constants.TELNET);
         if (StringUtils.isEmpty(supportCommands)) {
-            commandEnable = true;
-        } else {
-            String[] commands = 
Constants.COMMA_SPLIT_PATTERN.split(supportCommands);
-            for (String c : commands) {
-                if (command.equals(c)) {
-                    commandEnable = true;
-                    break;
-                }
+            return true;
+        }
+        String[] commands = 
Constants.COMMA_SPLIT_PATTERN.split(supportCommands);
+        for (String c : commands) {
+            if (command.equals(c)) {
+                return true;
             }
         }
-        return commandEnable;
+        return false;
     }
 
 }