This is an automated email from the ASF dual-hosted git repository. lixiaojie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-dubbo.git
The following commit(s) were added to refs/heads/master by this push: new 2e660df Dubbo-3473 Fix Not Properly Closed Resources (#3474) 2e660df is described below commit 2e660dfef7282b43bc58113df39e61b7a79bdf0e Author: Furkan KAMACI <furkankam...@gmail.com> AuthorDate: Thu Mar 7 13:08:55 2019 +0300 Dubbo-3473 Fix Not Properly Closed Resources (#3474) --- .../src/main/java/org/apache/dubbo/rpc/filter/GenericFilter.java | 3 +-- .../org/apache/dubbo/rpc/protocol/dubbo/telnet/LogTelnetHandler.java | 3 +-- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/dubbo-rpc/dubbo-rpc-api/src/main/java/org/apache/dubbo/rpc/filter/GenericFilter.java b/dubbo-rpc/dubbo-rpc-api/src/main/java/org/apache/dubbo/rpc/filter/GenericFilter.java index 7995468..ae7b92c 100644 --- a/dubbo-rpc/dubbo-rpc-api/src/main/java/org/apache/dubbo/rpc/filter/GenericFilter.java +++ b/dubbo-rpc/dubbo-rpc-api/src/main/java/org/apache/dubbo/rpc/filter/GenericFilter.java @@ -76,8 +76,7 @@ public class GenericFilter implements Filter { } else if (ProtocolUtils.isJavaGenericSerialization(generic)) { for (int i = 0; i < args.length; i++) { if (byte[].class == args[i].getClass()) { - try { - UnsafeByteArrayInputStream is = new UnsafeByteArrayInputStream((byte[]) args[i]); + try(UnsafeByteArrayInputStream is = new UnsafeByteArrayInputStream((byte[]) args[i])) { args[i] = ExtensionLoader.getExtensionLoader(Serialization.class) .getExtension(Constants.GENERIC_SERIALIZATION_NATIVE_JAVA) .deserialize(null, is).readObject(); diff --git a/dubbo-rpc/dubbo-rpc-dubbo/src/main/java/org/apache/dubbo/rpc/protocol/dubbo/telnet/LogTelnetHandler.java b/dubbo-rpc/dubbo-rpc-dubbo/src/main/java/org/apache/dubbo/rpc/protocol/dubbo/telnet/LogTelnetHandler.java index 5ab3c27..b62198d 100644 --- a/dubbo-rpc/dubbo-rpc-dubbo/src/main/java/org/apache/dubbo/rpc/protocol/dubbo/telnet/LogTelnetHandler.java +++ b/dubbo-rpc/dubbo-rpc-dubbo/src/main/java/org/apache/dubbo/rpc/protocol/dubbo/telnet/LogTelnetHandler.java @@ -55,8 +55,7 @@ public class LogTelnetHandler implements TelnetHandler { int showLogLength = Integer.parseInt(str[0]); if (file != null && file.exists()) { - try { - FileInputStream fis = new FileInputStream(file); + try(FileInputStream fis = new FileInputStream(file)) { FileChannel filechannel = fis.getChannel(); size = filechannel.size(); ByteBuffer bb;