This is an automated email from the ASF dual-hosted git repository.

iluo pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-dubbo.git


The following commit(s) were added to refs/heads/master by this push:
     new 2bfe25e  Make `dynamic` default true to promise that the url will 
delete from zk whenever provider shutdown. (#3824)
2bfe25e is described below

commit 2bfe25ebf2acebeb67c1d47aea21c3171a3798cd
Author: 时无两丶 <[email protected]>
AuthorDate: Tue Apr 9 10:16:05 2019 +0800

    Make `dynamic` default true to promise that the url will delete from zk 
whenever provider shutdown. (#3824)
---
 .../src/main/java/com/alibaba/dubbo/config/annotation/Service.java    | 2 +-
 .../src/main/java/org/apache/dubbo/config/AbstractServiceConfig.java  | 2 +-
 .../src/main/java/org/apache/dubbo/config/annotation/Service.java     | 4 ++--
 3 files changed, 4 insertions(+), 4 deletions(-)

diff --git 
a/dubbo-compatible/src/main/java/com/alibaba/dubbo/config/annotation/Service.java
 
b/dubbo-compatible/src/main/java/com/alibaba/dubbo/config/annotation/Service.java
index 1919a1e..6518dc8 100644
--- 
a/dubbo-compatible/src/main/java/com/alibaba/dubbo/config/annotation/Service.java
+++ 
b/dubbo-compatible/src/main/java/com/alibaba/dubbo/config/annotation/Service.java
@@ -47,7 +47,7 @@ public @interface Service {
 
     boolean deprecated() default false;
 
-    boolean dynamic() default false;
+    boolean dynamic() default true;
 
     String accesslog() default "";
 
diff --git 
a/dubbo-config/dubbo-config-api/src/main/java/org/apache/dubbo/config/AbstractServiceConfig.java
 
b/dubbo-config/dubbo-config-api/src/main/java/org/apache/dubbo/config/AbstractServiceConfig.java
index ba7f129..24ac6a2 100644
--- 
a/dubbo-config/dubbo-config-api/src/main/java/org/apache/dubbo/config/AbstractServiceConfig.java
+++ 
b/dubbo-config/dubbo-config-api/src/main/java/org/apache/dubbo/config/AbstractServiceConfig.java
@@ -74,7 +74,7 @@ public abstract class AbstractServiceConfig extends 
AbstractInterfaceConfig {
      * after the service registered,and it needs to be enabled manually; if 
you want to disable the service, you also need
      * manual processing
      */
-    protected Boolean dynamic = false;
+    protected Boolean dynamic = true;
 
     /**
      * Whether to use token
diff --git 
a/dubbo-config/dubbo-config-api/src/main/java/org/apache/dubbo/config/annotation/Service.java
 
b/dubbo-config/dubbo-config-api/src/main/java/org/apache/dubbo/config/annotation/Service.java
index 2e6f9b6..9db3ffd 100644
--- 
a/dubbo-config/dubbo-config-api/src/main/java/org/apache/dubbo/config/annotation/Service.java
+++ 
b/dubbo-config/dubbo-config-api/src/main/java/org/apache/dubbo/config/annotation/Service.java
@@ -79,9 +79,9 @@ public @interface Service {
     boolean deprecated() default false;
 
     /**
-     * Whether the service is dynamic, default value is false
+     * Whether the service is dynamic, default value is true
      */
-    boolean dynamic() default false;
+    boolean dynamic() default true;
 
     /**
      * Access log for the service, default value is ""

Reply via email to