This is an automated email from the ASF dual-hosted git repository.
iluo pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/dubbo.git
The following commit(s) were added to refs/heads/master by this push:
new d663ad4 [dubbo_4569]optimized code(#4569) (#4584)
d663ad4 is described below
commit d663ad45b1eed609308d098a2cd616474eefaa7e
Author: ouyangxi <[email protected]>
AuthorDate: Wed Jul 17 10:24:04 2019 +0800
[dubbo_4569]optimized code(#4569) (#4584)
* fix-4569
* fix-4569
---
.../apache/dubbo/common/extension/ExtensionLoader.java | 15 ++++++---------
1 file changed, 6 insertions(+), 9 deletions(-)
diff --git
a/dubbo-common/src/main/java/org/apache/dubbo/common/extension/ExtensionLoader.java
b/dubbo-common/src/main/java/org/apache/dubbo/common/extension/ExtensionLoader.java
index 4b5a44f..b1cd735 100644
---
a/dubbo-common/src/main/java/org/apache/dubbo/common/extension/ExtensionLoader.java
+++
b/dubbo-common/src/main/java/org/apache/dubbo/common/extension/ExtensionLoader.java
@@ -225,13 +225,11 @@ public class ExtensionLoader<T> {
} else {
continue;
}
- if (isMatchGroup(group, activateGroup)) {
- T ext = getExtension(name);
- if (!names.contains(name)
- && !names.contains(REMOVE_VALUE_PREFIX + name)
- && isActive(activateValue, url)) {
- exts.add(ext);
- }
+ if (isMatchGroup(group, activateGroup)
+ && !names.contains(name)
+ && !names.contains(REMOVE_VALUE_PREFIX + name)
+ && isActive(activateValue, url)) {
+ exts.add(getExtension(name));
}
}
exts.sort(ActivateComparator.COMPARATOR);
@@ -247,8 +245,7 @@ public class ExtensionLoader<T> {
usrs.clear();
}
} else {
- T ext = getExtension(name);
- usrs.add(ext);
+ usrs.add(getExtension(name));
}
}
}