This is an automated email from the ASF dual-hosted git repository.
liujun pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/dubbo.git
The following commit(s) were added to refs/heads/master by this push:
new 524cf95 add netty channel connected and disconnected log. (#5171)
524cf95 is described below
commit 524cf9561da11576a2765e86cdbb24b325a9929d
Author: Haiyang <[email protected]>
AuthorDate: Fri Oct 18 11:02:38 2019 +0800
add netty channel connected and disconnected log. (#5171)
---
.../apache/dubbo/remoting/transport/netty/NettyHandler.java | 12 ++++++++++++
.../dubbo/remoting/transport/netty4/NettyClientHandler.java | 12 ++++++++++--
.../dubbo/remoting/transport/netty4/NettyServerHandler.java | 8 ++++++++
3 files changed, 30 insertions(+), 2 deletions(-)
diff --git
a/dubbo-remoting/dubbo-remoting-netty/src/main/java/org/apache/dubbo/remoting/transport/netty/NettyHandler.java
b/dubbo-remoting/dubbo-remoting-netty/src/main/java/org/apache/dubbo/remoting/transport/netty/NettyHandler.java
index c256039..b8d0419 100644
---
a/dubbo-remoting/dubbo-remoting-netty/src/main/java/org/apache/dubbo/remoting/transport/netty/NettyHandler.java
+++
b/dubbo-remoting/dubbo-remoting-netty/src/main/java/org/apache/dubbo/remoting/transport/netty/NettyHandler.java
@@ -17,6 +17,8 @@
package org.apache.dubbo.remoting.transport.netty;
import org.apache.dubbo.common.URL;
+import org.apache.dubbo.common.logger.Logger;
+import org.apache.dubbo.common.logger.LoggerFactory;
import org.apache.dubbo.common.utils.NetUtils;
import org.apache.dubbo.remoting.Channel;
import org.apache.dubbo.remoting.ChannelHandler;
@@ -38,6 +40,8 @@ import java.util.concurrent.ConcurrentHashMap;
@Sharable
public class NettyHandler extends SimpleChannelHandler {
+ private static final Logger logger =
LoggerFactory.getLogger(NettyHandler.class);
+
private final Map<String, Channel> channels = new
ConcurrentHashMap<String, Channel>(); // <ip:port, channel>
private final URL url;
@@ -70,6 +74,10 @@ public class NettyHandler extends SimpleChannelHandler {
} finally {
NettyChannel.removeChannelIfDisconnected(ctx.getChannel());
}
+
+ if (logger.isInfoEnabled()) {
+ logger.info("The connection between " + channel.getRemoteAddress()
+ " and " + channel.getLocalAddress() + " is established");
+ }
}
@Override
@@ -81,6 +89,10 @@ public class NettyHandler extends SimpleChannelHandler {
} finally {
NettyChannel.removeChannelIfDisconnected(ctx.getChannel());
}
+
+ if (logger.isInfoEnabled()) {
+ logger.info("The connection between " + channel.getRemoteAddress()
+ " and " + channel.getLocalAddress() + " is disconnected");
+ }
}
@Override
diff --git
a/dubbo-remoting/dubbo-remoting-netty4/src/main/java/org/apache/dubbo/remoting/transport/netty4/NettyClientHandler.java
b/dubbo-remoting/dubbo-remoting-netty4/src/main/java/org/apache/dubbo/remoting/transport/netty4/NettyClientHandler.java
index 8ff2d98..fd18ba6 100644
---
a/dubbo-remoting/dubbo-remoting-netty4/src/main/java/org/apache/dubbo/remoting/transport/netty4/NettyClientHandler.java
+++
b/dubbo-remoting/dubbo-remoting-netty4/src/main/java/org/apache/dubbo/remoting/transport/netty4/NettyClientHandler.java
@@ -60,6 +60,10 @@ public class NettyClientHandler extends ChannelDuplexHandler
{
} finally {
NettyChannel.removeChannelIfDisconnected(ctx.channel());
}
+
+ if (logger.isInfoEnabled()) {
+ logger.info("The connection of " + channel.getLocalAddress() + "
-> " + channel.getRemoteAddress() + " is established.");
+ }
}
@Override
@@ -70,6 +74,10 @@ public class NettyClientHandler extends ChannelDuplexHandler
{
} finally {
NettyChannel.removeChannelIfDisconnected(ctx.channel());
}
+
+ if (logger.isInfoEnabled()) {
+ logger.info("The connection of " + channel.getLocalAddress() + "
-> " + channel.getRemoteAddress() + " is disconnected.");
+ }
}
@Override
@@ -113,7 +121,7 @@ public class NettyClientHandler extends
ChannelDuplexHandler {
@Override
public void userEventTriggered(ChannelHandlerContext ctx, Object evt)
throws Exception {
- // send heartbeat when read idle.
+ // send heartbeat when read idle.
if (evt instanceof IdleStateEvent) {
try {
NettyChannel channel =
NettyChannel.getOrAddChannel(ctx.channel(), url, handler);
@@ -128,7 +136,7 @@ public class NettyClientHandler extends
ChannelDuplexHandler {
} finally {
NettyChannel.removeChannelIfDisconnected(ctx.channel());
}
- } else {
+ } else {
super.userEventTriggered(ctx, evt);
}
}
diff --git
a/dubbo-remoting/dubbo-remoting-netty4/src/main/java/org/apache/dubbo/remoting/transport/netty4/NettyServerHandler.java
b/dubbo-remoting/dubbo-remoting-netty4/src/main/java/org/apache/dubbo/remoting/transport/netty4/NettyServerHandler.java
index e62ab72..0402589 100644
---
a/dubbo-remoting/dubbo-remoting-netty4/src/main/java/org/apache/dubbo/remoting/transport/netty4/NettyServerHandler.java
+++
b/dubbo-remoting/dubbo-remoting-netty4/src/main/java/org/apache/dubbo/remoting/transport/netty4/NettyServerHandler.java
@@ -74,6 +74,10 @@ public class NettyServerHandler extends ChannelDuplexHandler
{
} finally {
NettyChannel.removeChannelIfDisconnected(ctx.channel());
}
+
+ if (logger.isInfoEnabled()) {
+ logger.info("The connection of " + channel.getRemoteAddress() + "
-> " + channel.getLocalAddress() + " is established.");
+ }
}
@Override
@@ -85,6 +89,10 @@ public class NettyServerHandler extends ChannelDuplexHandler
{
} finally {
NettyChannel.removeChannelIfDisconnected(ctx.channel());
}
+
+ if (logger.isInfoEnabled()) {
+ logger.info("The connection of " + channel.getRemoteAddress() + "
-> " + channel.getLocalAddress() + " is disconnected.");
+ }
}
@Override