This is an automated email from the ASF dual-hosted git repository. liujun pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/dubbo.git
commit 562bfcc16a3f63e9f207726b2b7f4981d6aa9df3 Author: ken.lj <[email protected]> AuthorDate: Fri Nov 15 15:24:40 2019 +0800 Add comments for gRPC implementations --- .../main/java/org/apache/dubbo/rpc/protocol/grpc/GrpcProtocol.java | 5 +++-- .../dubbo/rpc/protocol/grpc/interceptors/ClientInterceptor.java | 3 +++ .../dubbo/rpc/protocol/grpc/interceptors/RpcContextInterceptor.java | 2 +- .../dubbo/rpc/protocol/grpc/interceptors/ServerInterceptor.java | 3 +++ .../dubbo/rpc/protocol/grpc/interceptors/ServerTransportFilter.java | 3 +++ 5 files changed, 13 insertions(+), 3 deletions(-) diff --git a/dubbo-rpc/dubbo-rpc-grpc/src/main/java/org/apache/dubbo/rpc/protocol/grpc/GrpcProtocol.java b/dubbo-rpc/dubbo-rpc-grpc/src/main/java/org/apache/dubbo/rpc/protocol/grpc/GrpcProtocol.java index aa862a5..83aaf7b 100644 --- a/dubbo-rpc/dubbo-rpc-grpc/src/main/java/org/apache/dubbo/rpc/protocol/grpc/GrpcProtocol.java +++ b/dubbo-rpc/dubbo-rpc-grpc/src/main/java/org/apache/dubbo/rpc/protocol/grpc/GrpcProtocol.java @@ -85,10 +85,11 @@ public class GrpcProtocol extends AbstractProxyProtocol { Class<?> implClass = originalImpl.getClass(); try { - Method method = implClass.getDeclaredMethod("setProxiedImpl", type); + Method method = implClass.getMethod("setProxiedImpl", type); method.invoke(originalImpl, proxiedImpl); } catch (Exception e) { - throw new IllegalStateException(); + throw new IllegalStateException("Failed to set dubbo proxied service impl to stub, please make sure your stub " + + "was generated by the dubbo-protoc-compiler.", e); } grpcServer.getRegistry().addService((BindableService) originalImpl, url.getServiceKey()); diff --git a/dubbo-rpc/dubbo-rpc-grpc/src/main/java/org/apache/dubbo/rpc/protocol/grpc/interceptors/ClientInterceptor.java b/dubbo-rpc/dubbo-rpc-grpc/src/main/java/org/apache/dubbo/rpc/protocol/grpc/interceptors/ClientInterceptor.java index 841b503..c97fec9 100644 --- a/dubbo-rpc/dubbo-rpc-grpc/src/main/java/org/apache/dubbo/rpc/protocol/grpc/interceptors/ClientInterceptor.java +++ b/dubbo-rpc/dubbo-rpc-grpc/src/main/java/org/apache/dubbo/rpc/protocol/grpc/interceptors/ClientInterceptor.java @@ -18,6 +18,9 @@ package org.apache.dubbo.rpc.protocol.grpc.interceptors; import org.apache.dubbo.common.extension.SPI; +/** + * Adapt to the standard Dubbo SPI, so that we can leverage the advantages of Dubbo ExtensionLoader. + */ @SPI public interface ClientInterceptor extends io.grpc.ClientInterceptor { } diff --git a/dubbo-rpc/dubbo-rpc-grpc/src/main/java/org/apache/dubbo/rpc/protocol/grpc/interceptors/RpcContextInterceptor.java b/dubbo-rpc/dubbo-rpc-grpc/src/main/java/org/apache/dubbo/rpc/protocol/grpc/interceptors/RpcContextInterceptor.java index 88c18ce..31059e8 100644 --- a/dubbo-rpc/dubbo-rpc-grpc/src/main/java/org/apache/dubbo/rpc/protocol/grpc/interceptors/RpcContextInterceptor.java +++ b/dubbo-rpc/dubbo-rpc-grpc/src/main/java/org/apache/dubbo/rpc/protocol/grpc/interceptors/RpcContextInterceptor.java @@ -34,7 +34,7 @@ import static org.apache.dubbo.common.constants.CommonConstants.CONSUMER; import static org.apache.dubbo.common.constants.CommonConstants.PROVIDER; /** - * From gRPC's + * Hand over context information from Dubbo to gRPC. */ @Activate(group = {PROVIDER, CONSUMER}) public class RpcContextInterceptor implements ClientInterceptor, ServerInterceptor { diff --git a/dubbo-rpc/dubbo-rpc-grpc/src/main/java/org/apache/dubbo/rpc/protocol/grpc/interceptors/ServerInterceptor.java b/dubbo-rpc/dubbo-rpc-grpc/src/main/java/org/apache/dubbo/rpc/protocol/grpc/interceptors/ServerInterceptor.java index fa876bc..a4c9a37 100644 --- a/dubbo-rpc/dubbo-rpc-grpc/src/main/java/org/apache/dubbo/rpc/protocol/grpc/interceptors/ServerInterceptor.java +++ b/dubbo-rpc/dubbo-rpc-grpc/src/main/java/org/apache/dubbo/rpc/protocol/grpc/interceptors/ServerInterceptor.java @@ -18,6 +18,9 @@ package org.apache.dubbo.rpc.protocol.grpc.interceptors; import org.apache.dubbo.common.extension.SPI; +/** + * Adapt to the standard Dubbo SPI, so that we can leverage the advantages of Dubbo ExtensionLoader. + */ @SPI public interface ServerInterceptor extends io.grpc.ServerInterceptor { } diff --git a/dubbo-rpc/dubbo-rpc-grpc/src/main/java/org/apache/dubbo/rpc/protocol/grpc/interceptors/ServerTransportFilter.java b/dubbo-rpc/dubbo-rpc-grpc/src/main/java/org/apache/dubbo/rpc/protocol/grpc/interceptors/ServerTransportFilter.java index aa8dda9..db815dc 100644 --- a/dubbo-rpc/dubbo-rpc-grpc/src/main/java/org/apache/dubbo/rpc/protocol/grpc/interceptors/ServerTransportFilter.java +++ b/dubbo-rpc/dubbo-rpc-grpc/src/main/java/org/apache/dubbo/rpc/protocol/grpc/interceptors/ServerTransportFilter.java @@ -18,6 +18,9 @@ package org.apache.dubbo.rpc.protocol.grpc.interceptors; import org.apache.dubbo.common.extension.SPI; +/** + * Adapt to the standard Dubbo SPI, so that we can leverage the advantages of Dubbo ExtensionLoader. + */ @SPI public interface ServerTransportFilter { io.grpc.ServerTransportFilter grpcTransportFilter();
