[dubbo] branch master updated: refactoring to remove feature envy. (#5559)

[liujun]

This is an automated email from the ASF dual-hosted git repository.

liujun pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/dubbo.git


The following commit(s) were added to refs/heads/master by this push:
     new cd509a3  refactoring to remove feature envy. (#5559)
cd509a3 is described below

commit cd509a3b0c3f1016585ada3fc7c8516e50170c33
Author: Kleber Tarcísio <klebertarci...@yahoo.com.br>
AuthorDate: Mon Feb 10 05:22:09 2020 -0300

    refactoring to remove feature envy. (#5559)
---
 .../apache/dubbo/config/AbstractInterfaceConfig.java | 20 ++++++++++----------
 1 file changed, 10 insertions(+), 10 deletions(-)

diff --git 
a/dubbo-common/src/main/java/org/apache/dubbo/config/AbstractInterfaceConfig.java
 
b/dubbo-common/src/main/java/org/apache/dubbo/config/AbstractInterfaceConfig.java
index 884a1e2..46eca04 100644
--- 
a/dubbo-common/src/main/java/org/apache/dubbo/config/AbstractInterfaceConfig.java
+++ 
b/dubbo-common/src/main/java/org/apache/dubbo/config/AbstractInterfaceConfig.java
@@ -243,16 +243,16 @@ public abstract class AbstractInterfaceConfig extends 
AbstractMethodConfig {
      *                       side, it is the {@link Class} of the remote 
service interface
      */
     public void checkStubAndLocal(Class<?> interfaceClass) {
-        if (ConfigUtils.isNotEmpty(local)) {
-            Class<?> localClass = ConfigUtils.isDefault(local) ?
-                    ReflectUtils.forName(interfaceClass.getName() + "Local") : 
ReflectUtils.forName(local);
-            verify(interfaceClass, localClass);
-        }
-        if (ConfigUtils.isNotEmpty(stub)) {
-            Class<?> localClass = ConfigUtils.isDefault(stub) ?
-                    ReflectUtils.forName(interfaceClass.getName() + "Stub") : 
ReflectUtils.forName(stub);
-            verify(interfaceClass, localClass);
-        }
+        verifyStubAndLocal(local, "Local", interfaceClass);
+        verifyStubAndLocal(stub, "Stub", interfaceClass);
+    }
+    
+    public void verifyStubAndLocal(String className, String label, Class<?> 
interfaceClass){
+       if (ConfigUtils.isNotEmpty(className)) {
+                Class<?> localClass = ConfigUtils.isDefault(className) ?
+                        ReflectUtils.forName(interfaceClass.getName() + label) 
:                       ReflectUtils.forName(className);
+                        verify(interfaceClass, localClass);
+            }
     }
 
     private void verify(Class<?> interfaceClass, Class<?> localClass) {