[dubbo] branch master updated: extracting duplicate code in CountTelnetHandler (#5824)

[hyunkun]

This is an automated email from the ASF dual-hosted git repository.

hyunkun pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/dubbo.git


The following commit(s) were added to refs/heads/master by this push:
     new 7b92414  extracting duplicate code in CountTelnetHandler (#5824)
7b92414 is described below

commit 7b92414ef3707d2cd4a69ec6131cc03fd8eed8ab
Author: Huang YunKun <hty...@gmail.com>
AuthorDate: Thu Mar 5 07:01:28 2020 -0600

    extracting duplicate code in CountTelnetHandler (#5824)
---
 .../dubbo/qos/legacy/CountTelnetHandler.java       | 28 ++++++++++------------
 1 file changed, 12 insertions(+), 16 deletions(-)

diff --git 
a/dubbo-plugin/dubbo-qos/src/main/java/org/apache/dubbo/qos/legacy/CountTelnetHandler.java
 
b/dubbo-plugin/dubbo-qos/src/main/java/org/apache/dubbo/qos/legacy/CountTelnetHandler.java
index 3b79bea..cab2799 100644
--- 
a/dubbo-plugin/dubbo-qos/src/main/java/org/apache/dubbo/qos/legacy/CountTelnetHandler.java
+++ 
b/dubbo-plugin/dubbo-qos/src/main/java/org/apache/dubbo/qos/legacy/CountTelnetHandler.java
@@ -130,14 +130,7 @@ public class CountTelnetHandler implements TelnetHandler {
         if (method == null || method.length() == 0) {
             for (Method m : invoker.getInterface().getMethods()) {
                 RpcStatus count = RpcStatus.getStatus(url, m.getName());
-                List<String> row = new ArrayList<String>();
-                row.add(m.getName());
-                row.add(String.valueOf(count.getTotal()));
-                row.add(String.valueOf(count.getFailed()));
-                row.add(String.valueOf(count.getActive()));
-                row.add(String.valueOf(count.getSucceededAverageElapsed()) + 
"ms");
-                row.add(String.valueOf(count.getSucceededMaxElapsed()) + "ms");
-                table.add(row);
+                table.add(createRow(m.getName(),count));
             }
         } else {
             boolean found = false;
@@ -149,14 +142,7 @@ public class CountTelnetHandler implements TelnetHandler {
             }
             if (found) {
                 RpcStatus count = RpcStatus.getStatus(url, method);
-                List<String> row = new ArrayList<String>();
-                row.add(method);
-                row.add(String.valueOf(count.getTotal()));
-                row.add(String.valueOf(count.getFailed()));
-                row.add(String.valueOf(count.getActive()));
-                row.add(String.valueOf(count.getSucceededAverageElapsed()) + 
"ms");
-                row.add(String.valueOf(count.getSucceededMaxElapsed()) + "ms");
-                table.add(row);
+                table.add(createRow(method,count));
             } else {
                 return "No such method " + method + " in class " + 
invoker.getInterface().getName();
             }
@@ -164,4 +150,14 @@ public class CountTelnetHandler implements TelnetHandler {
         return TelnetUtils.toTable(header, table);
     }
 
+    private List<String> createRow(String methodName,RpcStatus count) {
+        List<String> row = new ArrayList<String>();
+        row.add(methodName);
+        row.add(String.valueOf(count.getTotal()));
+        row.add(String.valueOf(count.getFailed()));
+        row.add(String.valueOf(count.getActive()));
+        row.add(count.getSucceededAverageElapsed() + "ms");
+        row.add(count.getSucceededMaxElapsed() + "ms");
+        return row;
+    }
 }