This is an automated email from the ASF dual-hosted git repository.
liujun pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/dubbo.git
The following commit(s) were added to refs/heads/master by this push:
new a0be776 do not set default id (#6236)
a0be776 is described below
commit a0be7765c9627786bf48abee1db47d317cde84e5
Author: ken.lj <[email protected]>
AuthorDate: Fri May 29 13:44:08 2020 +0800
do not set default id (#6236)
---
.../src/main/java/org/apache/dubbo/config/MethodConfig.java | 7 ++++---
.../src/main/java/org/apache/dubbo/config/ReferenceConfigBase.java | 7 ++++---
.../src/main/java/org/apache/dubbo/config/ServiceConfigBase.java | 7 ++++---
3 files changed, 12 insertions(+), 9 deletions(-)
diff --git
a/dubbo-common/src/main/java/org/apache/dubbo/config/MethodConfig.java
b/dubbo-common/src/main/java/org/apache/dubbo/config/MethodConfig.java
index 1dca2aa..a073b61 100644
--- a/dubbo-common/src/main/java/org/apache/dubbo/config/MethodConfig.java
+++ b/dubbo-common/src/main/java/org/apache/dubbo/config/MethodConfig.java
@@ -169,9 +169,10 @@ public class MethodConfig extends AbstractMethodConfig {
public void setName(String name) {
this.name = name;
- if (StringUtils.isEmpty(id)) {
- id = name;
- }
+ // FIXME, add id strategy in ConfigManager
+// if (StringUtils.isEmpty(id)) {
+// id = name;
+// }
}
public Integer getStat() {
diff --git
a/dubbo-common/src/main/java/org/apache/dubbo/config/ReferenceConfigBase.java
b/dubbo-common/src/main/java/org/apache/dubbo/config/ReferenceConfigBase.java
index a022813..966b384 100644
---
a/dubbo-common/src/main/java/org/apache/dubbo/config/ReferenceConfigBase.java
+++
b/dubbo-common/src/main/java/org/apache/dubbo/config/ReferenceConfigBase.java
@@ -166,9 +166,10 @@ public abstract class ReferenceConfigBase<T> extends
AbstractReferenceConfig {
public void setInterface(String interfaceName) {
this.interfaceName = interfaceName;
- if (StringUtils.isEmpty(id)) {
- id = interfaceName;
- }
+ // FIXME, add id strategy in ConfigManager
+// if (StringUtils.isEmpty(id)) {
+// id = interfaceName;
+// }
}
public void setInterface(Class<?> interfaceClass) {
diff --git
a/dubbo-common/src/main/java/org/apache/dubbo/config/ServiceConfigBase.java
b/dubbo-common/src/main/java/org/apache/dubbo/config/ServiceConfigBase.java
index 650d74c..24f5176 100644
--- a/dubbo-common/src/main/java/org/apache/dubbo/config/ServiceConfigBase.java
+++ b/dubbo-common/src/main/java/org/apache/dubbo/config/ServiceConfigBase.java
@@ -306,9 +306,10 @@ public abstract class ServiceConfigBase<T> extends
AbstractServiceConfig {
public void setInterface(String interfaceName) {
this.interfaceName = interfaceName;
- if (StringUtils.isEmpty(id)) {
- id = interfaceName;
- }
+ // FIXME, add id strategy in ConfigManager
+// if (StringUtils.isEmpty(id)) {
+// id = interfaceName;
+// }
}
public T getRef() {
