This is an automated email from the ASF dual-hosted git repository.

albumenj pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/dubbo.git


The following commit(s) were added to refs/heads/master by this push:
     new e4f19e5  [Dubbo-7332] Fix QOS Ready command (#7333)
e4f19e5 is described below

commit e4f19e5faa983ba02da3af5b9a9dfdeb81ede920
Author: Nick Wong <[email protected]>
AuthorDate: Thu Mar 11 19:18:01 2021 +0800

    [Dubbo-7332] Fix QOS Ready command (#7333)
    
    * [Dubbo-7332] Fix QOS Ready command
    
    Fix QOS Ready command return OK when DubboBootstrap is not ready
    
    * Add setter for ready in DubboBootstrap
    
    * set DubboBootstrap ready to true after ServiceConfig doExport
---
 .../src/main/java/org/apache/dubbo/config/ServiceConfig.java        | 1 +
 .../main/java/org/apache/dubbo/config/bootstrap/DubboBootstrap.java | 6 +++++-
 2 files changed, 6 insertions(+), 1 deletion(-)

diff --git 
a/dubbo-config/dubbo-config-api/src/main/java/org/apache/dubbo/config/ServiceConfig.java
 
b/dubbo-config/dubbo-config-api/src/main/java/org/apache/dubbo/config/ServiceConfig.java
index e95fa08..6c720a8 100644
--- 
a/dubbo-config/dubbo-config-api/src/main/java/org/apache/dubbo/config/ServiceConfig.java
+++ 
b/dubbo-config/dubbo-config-api/src/main/java/org/apache/dubbo/config/ServiceConfig.java
@@ -300,6 +300,7 @@ public class ServiceConfig<T> extends ServiceConfigBase<T> {
             path = interfaceName;
         }
         doExportUrls();
+        bootstrap.setReady(true);
     }
 
     @SuppressWarnings({"unchecked", "rawtypes"})
diff --git 
a/dubbo-config/dubbo-config-api/src/main/java/org/apache/dubbo/config/bootstrap/DubboBootstrap.java
 
b/dubbo-config/dubbo-config-api/src/main/java/org/apache/dubbo/config/bootstrap/DubboBootstrap.java
index 2fd206e..944d6ad 100644
--- 
a/dubbo-config/dubbo-config-api/src/main/java/org/apache/dubbo/config/bootstrap/DubboBootstrap.java
+++ 
b/dubbo-config/dubbo-config-api/src/main/java/org/apache/dubbo/config/bootstrap/DubboBootstrap.java
@@ -172,7 +172,7 @@ public class DubboBootstrap extends GenericEventListener {
 
     private AtomicBoolean started = new AtomicBoolean(false);
 
-    private AtomicBoolean ready = new AtomicBoolean(true);
+    private AtomicBoolean ready = new AtomicBoolean(false);
 
     private AtomicBoolean destroyed = new AtomicBoolean(false);
 
@@ -1404,4 +1404,8 @@ public class DubboBootstrap extends GenericEventListener {
         ssl.refresh();
         return ssl;
     }
+    
+    public void setReady(boolean ready) {
+        this.ready.set(ready);
+    }
 }

Reply via email to