This is an automated email from the ASF dual-hosted git repository.

xiaoliu pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/dubbo-go-pixiu.git


The following commit(s) were added to refs/heads/develop by this push:
     new 2b4af4d  FixBug: can't delete node by path (#201)
2b4af4d is described below

commit 2b4af4d50480acd54271af1fd207709d649190d6
Author: randy <[email protected]>
AuthorDate: Sun Jul 4 21:50:31 2021 +0800

    FixBug: can't delete node by path (#201)
    
    * fix bug can't delete node
    
    * rm return statement
---
 pkg/config/api_config.go |  3 +--
 pkg/router/route.go      | 11 ++++-------
 2 files changed, 5 insertions(+), 9 deletions(-)

diff --git a/pkg/config/api_config.go b/pkg/config/api_config.go
index 4e62f60..b2b3c79 100644
--- a/pkg/config/api_config.go
+++ b/pkg/config/api_config.go
@@ -340,9 +340,8 @@ func listenResourceAndMethodEvent(key string) bool {
                                case mvccpb.DELETE:
                                        logger.Infof("get event (key{%s}) = 
event{EventNodeDeleted}", event.Kv.Key)
                                        handleDeleteEvent(event.Kv.Key, 
event.Kv.Value)
-                                       return true
                                default:
-                                       return false
+                                       logger.Infof("get event (key{%s}) = 
event{%d}", event.Kv.Key, event.Type)
                                }
                        }
                }
diff --git a/pkg/router/route.go b/pkg/router/route.go
index 9468833..dcc3cd0 100644
--- a/pkg/router/route.go
+++ b/pkg/router/route.go
@@ -123,13 +123,10 @@ func (rt *Route) FindAPI(fullPath string, httpverb 
config.HTTPVerb) (*router.API
 // DeleteNode delete node by fullPath
 func (rt *Route) DeleteNode(fullPath string) bool {
        lowerPath := strings.ToLower(fullPath)
-       if _, found := rt.searchWildcard(lowerPath); found {
-               rt.lock.RLock()
-               defer rt.lock.RUnlock()
-               rt.tree.Remove(lowerPath)
-               return true
-       }
-       return false
+       rt.lock.RLock()
+       defer rt.lock.RUnlock()
+       rt.tree.Remove(lowerPath)
+       return true
 }
 
 // DeleteAPI delete api by fullPath and http verb

Reply via email to