[dubbo] branch master updated: refactor MethodConfig by using mocking object created by Mockito (#8446)

[albumenj]

This is an automated email from the ASF dual-hosted git repository.

albumenj pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/dubbo.git


The following commit(s) were added to refs/heads/master by this push:
     new 27d834f  refactor MethodConfig by using mocking object created by 
Mockito (#8446)
27d834f is described below

commit 27d834f6ace9d5a1d9f5600be1d037979228923a
Author: wx930910 <wx19930...@gmail.com>
AuthorDate: Sun Aug 15 05:45:24 2021 -0400

    refactor MethodConfig by using mocking object created by Mockito (#8446)
---
 .../dubbo/config/AbstractMethodConfigTest.java     | 41 +++++++++++++---------
 1 file changed, 25 insertions(+), 16 deletions(-)

diff --git 
a/dubbo-config/dubbo-config-api/src/test/java/org/apache/dubbo/config/AbstractMethodConfigTest.java
 
b/dubbo-config/dubbo-config-api/src/test/java/org/apache/dubbo/config/AbstractMethodConfigTest.java
index 5b82bc8..80d2498 100644
--- 
a/dubbo-config/dubbo-config-api/src/test/java/org/apache/dubbo/config/AbstractMethodConfigTest.java
+++ 
b/dubbo-config/dubbo-config-api/src/test/java/org/apache/dubbo/config/AbstractMethodConfigTest.java
@@ -26,60 +26,69 @@ import static org.hamcrest.Matchers.equalTo;
 import static org.hamcrest.Matchers.is;
 import static org.hamcrest.Matchers.isEmptyOrNullString;
 import static org.hamcrest.Matchers.sameInstance;
+import static org.mockito.Mockito.spy;
 
 public class AbstractMethodConfigTest {
     @Test
     public void testTimeout() throws Exception {
-        MethodConfig methodConfig = new MethodConfig();
+        // Construct mock object
+        AbstractMethodConfig methodConfig = spy(AbstractMethodConfig.class);
         methodConfig.setTimeout(10);
         assertThat(methodConfig.getTimeout(), equalTo(10));
     }
 
     @Test
     public void testForks() throws Exception {
-        MethodConfig methodConfig = new MethodConfig();
+        // Construct mock object
+        AbstractMethodConfig methodConfig = spy(AbstractMethodConfig.class);
         methodConfig.setForks(10);
         assertThat(methodConfig.getForks(), equalTo(10));
     }
 
     @Test
     public void testRetries() throws Exception {
-        MethodConfig methodConfig = new MethodConfig();
+        // Construct mock object
+        AbstractMethodConfig methodConfig = spy(AbstractMethodConfig.class);
         methodConfig.setRetries(3);
         assertThat(methodConfig.getRetries(), equalTo(3));
     }
 
     @Test
     public void testLoadbalance() throws Exception {
-        MethodConfig methodConfig = new MethodConfig();
+        // Construct mock object
+        AbstractMethodConfig methodConfig = spy(AbstractMethodConfig.class);
         methodConfig.setLoadbalance("mockloadbalance");
         assertThat(methodConfig.getLoadbalance(), equalTo("mockloadbalance"));
     }
 
     @Test
     public void testAsync() throws Exception {
-        MethodConfig methodConfig = new MethodConfig();
+        // Construct mock object
+        AbstractMethodConfig methodConfig = spy(AbstractMethodConfig.class);
         methodConfig.setAsync(true);
         assertThat(methodConfig.isAsync(), is(true));
     }
 
     @Test
     public void testActives() throws Exception {
-        MethodConfig methodConfig = new MethodConfig();
+        // Construct mock object
+        AbstractMethodConfig methodConfig = spy(AbstractMethodConfig.class);
         methodConfig.setActives(10);
         assertThat(methodConfig.getActives(), equalTo(10));
     }
 
     @Test
     public void testSent() throws Exception {
-        MethodConfig methodConfig = new MethodConfig();
+        // Construct mock object
+        AbstractMethodConfig methodConfig = spy(AbstractMethodConfig.class);
         methodConfig.setSent(true);
         assertThat(methodConfig.getSent(), is(true));
     }
 
     @Test
     public void testMock() throws Exception {
-        MethodConfig methodConfig = new MethodConfig();
+        // Construct mock object
+        AbstractMethodConfig methodConfig = spy(AbstractMethodConfig.class);
         methodConfig.setMock((Boolean) null);
         assertThat(methodConfig.getMock(), isEmptyOrNullString());
         methodConfig.setMock(true);
@@ -92,35 +101,35 @@ public class AbstractMethodConfigTest {
 
     @Test
     public void testMerger() throws Exception {
-        MethodConfig methodConfig = new MethodConfig();
+        // Construct mock object
+        AbstractMethodConfig methodConfig = spy(AbstractMethodConfig.class);
         methodConfig.setMerger("merger");
         assertThat(methodConfig.getMerger(), equalTo("merger"));
     }
 
     @Test
     public void testCache() throws Exception {
-        MethodConfig methodConfig = new MethodConfig();
+        // Construct mock object
+        AbstractMethodConfig methodConfig = spy(AbstractMethodConfig.class);
         methodConfig.setCache("cache");
         assertThat(methodConfig.getCache(), equalTo("cache"));
     }
 
     @Test
     public void testValidation() throws Exception {
-        MethodConfig methodConfig = new MethodConfig();
+        // Construct mock object
+        AbstractMethodConfig methodConfig = spy(AbstractMethodConfig.class);
         methodConfig.setValidation("validation");
         assertThat(methodConfig.getValidation(), equalTo("validation"));
     }
 
     @Test
     public void testParameters() throws Exception {
-        MethodConfig methodConfig = new MethodConfig();
+        // Construct mock object
+        AbstractMethodConfig methodConfig = spy(AbstractMethodConfig.class);
         Map<String, String> parameters = new HashMap<String, String>();
         parameters.put("key", "value");
         methodConfig.setParameters(parameters);
         assertThat(methodConfig.getParameters(), sameInstance(parameters));
     }
-
-    private static class MethodConfig extends AbstractMethodConfig {
-
-    }
 }