This is an automated email from the ASF dual-hosted git repository.

albumenj pushed a commit to branch 3.0
in repository https://gitbox.apache.org/repos/asf/dubbo.git


The following commit(s) were added to refs/heads/3.0 by this push:
     new 592c818  improve annotation parameters test (#8535)
592c818 is described below

commit 592c818d4a2623faf703ddd8277bd688987f9b7f
Author: Gong Dewei <[email protected]>
AuthorDate: Mon Aug 23 12:53:26 2021 +0800

    improve annotation parameters test (#8535)
---
 .../org/apache/dubbo/config/spring/util/DubboAnnotationUtils.java    | 3 ++-
 .../config/spring/beans/factory/annotation/ParameterConvertTest.java | 5 +++++
 2 files changed, 7 insertions(+), 1 deletion(-)

diff --git 
a/dubbo-config/dubbo-config-spring/src/main/java/org/apache/dubbo/config/spring/util/DubboAnnotationUtils.java
 
b/dubbo-config/dubbo-config-spring/src/main/java/org/apache/dubbo/config/spring/util/DubboAnnotationUtils.java
index f36697d..c8f5a23 100644
--- 
a/dubbo-config/dubbo-config-spring/src/main/java/org/apache/dubbo/config/spring/util/DubboAnnotationUtils.java
+++ 
b/dubbo-config/dubbo-config-spring/src/main/java/org/apache/dubbo/config/spring/util/DubboAnnotationUtils.java
@@ -144,7 +144,8 @@ public class DubboAnnotationUtils {
      * ["a=b"] ==>{a=b}
      * ["a:b"] ==>{a=b}
      * ["a=b","c","d"] ==>{a=b,c=d}
-     * ["a","a:b"] ==>{a=a:b}
+     * ["a","a:b"] ==>{a="a:b"}
+     * ["a","a,b"] ==>{a="a,b"}
      * </p>
      *
      * @param parameters
diff --git 
a/dubbo-config/dubbo-config-spring/src/test/java/org/apache/dubbo/config/spring/beans/factory/annotation/ParameterConvertTest.java
 
b/dubbo-config/dubbo-config-spring/src/test/java/org/apache/dubbo/config/spring/beans/factory/annotation/ParameterConvertTest.java
index d32e4ec..e74d0c4 100644
--- 
a/dubbo-config/dubbo-config-spring/src/test/java/org/apache/dubbo/config/spring/beans/factory/annotation/ParameterConvertTest.java
+++ 
b/dubbo-config/dubbo-config-spring/src/test/java/org/apache/dubbo/config/spring/beans/factory/annotation/ParameterConvertTest.java
@@ -56,5 +56,10 @@ public class ParameterConvertTest {
         parametersMap.clear();
         parametersMap.put("a", "a:b");
         Assertions.assertEquals(parametersMap, 
DubboAnnotationUtils.convertParameters(new String[]{"a", "a:b"}));
+
+        parametersMap.clear();
+        parametersMap.put("a", "0,100");
+        Assertions.assertEquals(parametersMap, 
DubboAnnotationUtils.convertParameters(new String[]{"a", "0,100"}));
+
     }
 }

Reply via email to