This is an automated email from the ASF dual-hosted git repository.

albumenj pushed a commit to branch 3.0
in repository https://gitbox.apache.org/repos/asf/dubbo.git


The following commit(s) were added to refs/heads/3.0 by this push:
     new f7933b7  Fix MetadataService connections leak (#8555)
f7933b7 is described below

commit f7933b735b4e051b7378418cc0688c3c3890069b
Author: Albumen Kevin <[email protected]>
AuthorDate: Mon Aug 23 13:40:12 2021 +0800

    Fix MetadataService connections leak (#8555)
---
 .../registry/client/event/listener/ServiceInstancesChangedListener.java  | 1 +
 1 file changed, 1 insertion(+)

diff --git 
a/dubbo-registry/dubbo-registry-api/src/main/java/org/apache/dubbo/registry/client/event/listener/ServiceInstancesChangedListener.java
 
b/dubbo-registry/dubbo-registry-api/src/main/java/org/apache/dubbo/registry/client/event/listener/ServiceInstancesChangedListener.java
index bae3450..a023275 100644
--- 
a/dubbo-registry/dubbo-registry-api/src/main/java/org/apache/dubbo/registry/client/event/listener/ServiceInstancesChangedListener.java
+++ 
b/dubbo-registry/dubbo-registry-api/src/main/java/org/apache/dubbo/registry/client/event/listener/ServiceInstancesChangedListener.java
@@ -336,6 +336,7 @@ public class ServiceInstancesChangedListener {
                 // change the instance used to communicate to avoid all 
requests route to the same instance
                 MetadataService metadataServiceProxy = 
MetadataUtils.getMetadataServiceProxy(instance);
                 metadataInfo = 
metadataServiceProxy.getMetadataInfo(ServiceInstanceMetadataUtils.getExportedServicesRevision(instance));
+                MetadataUtils.destroyMetadataServiceProxy(instance);
             }
         } catch (Exception e) {
             logger.error("Failed to load service metadata, meta type is " + 
metadataType, e);

Reply via email to