This is an automated email from the ASF dual-hosted git repository.

albumenj pushed a commit to branch 3.0
in repository https://gitbox.apache.org/repos/asf/dubbo.git


The following commit(s) were added to refs/heads/3.0 by this push:
     new ab26f9e  optimize of DefaultFilterChainBuilder (#9324)
ab26f9e is described below

commit ab26f9ed9fafe2e24c1d9929fabb799c724a5f91
Author: Wang Chengming <[email protected]>
AuthorDate: Sun Nov 28 23:15:44 2021 +0800

    optimize of DefaultFilterChainBuilder (#9324)
---
 .../apache/dubbo/rpc/cluster/filter/DefaultFilterChainBuilder.java | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git 
a/dubbo-cluster/src/main/java/org/apache/dubbo/rpc/cluster/filter/DefaultFilterChainBuilder.java
 
b/dubbo-cluster/src/main/java/org/apache/dubbo/rpc/cluster/filter/DefaultFilterChainBuilder.java
index 478ad66..eb4d35e 100644
--- 
a/dubbo-cluster/src/main/java/org/apache/dubbo/rpc/cluster/filter/DefaultFilterChainBuilder.java
+++ 
b/dubbo-cluster/src/main/java/org/apache/dubbo/rpc/cluster/filter/DefaultFilterChainBuilder.java
@@ -18,6 +18,7 @@ package org.apache.dubbo.rpc.cluster.filter;
 
 import org.apache.dubbo.common.URL;
 import org.apache.dubbo.common.extension.Activate;
+import org.apache.dubbo.common.utils.CollectionUtils;
 import org.apache.dubbo.rpc.Filter;
 import org.apache.dubbo.rpc.Invoker;
 import org.apache.dubbo.rpc.cluster.ClusterInvoker;
@@ -25,7 +26,7 @@ import org.apache.dubbo.rpc.model.ScopeModelUtil;
 
 import java.util.List;
 
-@Activate(order = 0)
+@Activate
 public class DefaultFilterChainBuilder implements FilterChainBuilder {
 
     /**
@@ -37,7 +38,7 @@ public class DefaultFilterChainBuilder implements 
FilterChainBuilder {
         URL url = originalInvoker.getUrl();
         List<Filter> filters = ScopeModelUtil.getExtensionLoader(Filter.class, 
url.getScopeModel()).getActivateExtension(url, key, group);
 
-        if (!filters.isEmpty()) {
+        if (!CollectionUtils.isEmpty(filters)) {
             for (int i = filters.size() - 1; i >= 0; i--) {
                 final Filter filter = filters.get(i);
                 final Invoker<T> next = last;
@@ -57,7 +58,7 @@ public class DefaultFilterChainBuilder implements 
FilterChainBuilder {
         URL url = originalInvoker.getUrl();
         List<ClusterFilter> filters = 
ScopeModelUtil.getExtensionLoader(ClusterFilter.class, 
url.getScopeModel()).getActivateExtension(url, key, group);
 
-        if (!filters.isEmpty()) {
+        if (!CollectionUtils.isEmpty(filters)) {
             for (int i = filters.size() - 1; i >= 0; i--) {
                 final ClusterFilter filter = filters.get(i);
                 final Invoker<T> next = last;

Reply via email to