[dubbo] branch 3.0 updated: optimize unit test (#9844)

[crazyhzm]

This is an automated email from the ASF dual-hosted git repository.

crazyhzm pushed a commit to branch 3.0
in repository https://gitbox.apache.org/repos/asf/dubbo.git


The following commit(s) were added to refs/heads/3.0 by this push:
     new 467cc17  optimize unit test (#9844)
467cc17 is described below

commit 467cc17bb936e74d5981115a7b01ccd668d78fa4
Author: Oliver <wqdyx...@163.com>
AuthorDate: Mon Mar 28 10:08:27 2022 +0800

    optimize unit test (#9844)
    
    * optimize unit test
    
    * fix test case
---
 .../configurator/absent/AbsentConfiguratorTest.java        |  8 ++++----
 .../rpc/cluster/configurator/parser/ConfigParserTest.java  | 14 +++++++-------
 2 files changed, 11 insertions(+), 11 deletions(-)

diff --git 
a/dubbo-cluster/src/test/java/org/apache/dubbo/rpc/cluster/configurator/absent/AbsentConfiguratorTest.java
 
b/dubbo-cluster/src/test/java/org/apache/dubbo/rpc/cluster/configurator/absent/AbsentConfiguratorTest.java
index 1949280..155f1a5 100644
--- 
a/dubbo-cluster/src/test/java/org/apache/dubbo/rpc/cluster/configurator/absent/AbsentConfiguratorTest.java
+++ 
b/dubbo-cluster/src/test/java/org/apache/dubbo/rpc/cluster/configurator/absent/AbsentConfiguratorTest.java
@@ -90,8 +90,8 @@ public class AbsentConfiguratorTest {
             // The host of configuratorUrl is 0.0.0.0 or the local address is 
the same as consumerUrlV27
             // same appName
             URL url = configurator.configure(URL.valueOf(consumerUrlV27));
-            Assertions.assertEquals(url.getParameter("timeout"), "100");
-            Assertions.assertEquals(url.getParameter("weight"), "200");
+            Assertions.assertEquals("100", url.getParameter("timeout"));
+            Assertions.assertEquals("200", url.getParameter("weight"));
         }
 
         {
@@ -112,8 +112,8 @@ public class AbsentConfiguratorTest {
             // same appName
             AbsentConfigurator configurator = new 
AbsentConfigurator(providerConfiguratorUrl);
             URL url = configurator.configure(URL.valueOf(providerUrlV27));
-            Assertions.assertEquals(url.getParameter("timeout"), "20000");
-            Assertions.assertEquals(url.getParameter("weight"), "100");
+            Assertions.assertEquals("20000", url.getParameter("timeout"));
+            Assertions.assertEquals("100", url.getParameter("weight"));
         }
     }
 
diff --git 
a/dubbo-cluster/src/test/java/org/apache/dubbo/rpc/cluster/configurator/parser/ConfigParserTest.java
 
b/dubbo-cluster/src/test/java/org/apache/dubbo/rpc/cluster/configurator/parser/ConfigParserTest.java
index 3b10d5b..91b4360 100644
--- 
a/dubbo-cluster/src/test/java/org/apache/dubbo/rpc/cluster/configurator/parser/ConfigParserTest.java
+++ 
b/dubbo-cluster/src/test/java/org/apache/dubbo/rpc/cluster/configurator/parser/ConfigParserTest.java
@@ -51,7 +51,7 @@ public class ConfigParserTest {
             Yaml yaml = new Yaml(new SafeConstructor());
             Map<String, Object> map = yaml.load(yamlStream);
             ConfiguratorConfig config = ConfiguratorConfig.parseFromMap(map);
-            System.out.println(config);
+            Assertions.assertNotNull(config);
         }
     }
 
@@ -62,8 +62,8 @@ public class ConfigParserTest {
             Assertions.assertNotNull(urls);
             Assertions.assertEquals(2, urls.size());
             URL url = urls.get(0);
-            Assertions.assertEquals(url.getAddress(), "127.0.0.1:20880");
-            Assertions.assertEquals(url.getParameter(WEIGHT_KEY, 0), 222);
+            Assertions.assertEquals("127.0.0.1:20880", url.getAddress());
+            Assertions.assertEquals(222, url.getParameter(WEIGHT_KEY, 0));
         }
     }
 
@@ -114,7 +114,7 @@ public class ConfigParserTest {
             Assertions.assertEquals("service1", url.getServiceInterface());
             Assertions.assertEquals(6666, url.getParameter(TIMEOUT_KEY, 0));
             Assertions.assertEquals("random", 
url.getParameter(LOADBALANCE_KEY));
-            Assertions.assertEquals(url.getApplication(), "demo-consumer");
+            Assertions.assertEquals("demo-consumer", url.getApplication());
         }
     }
 
@@ -130,7 +130,7 @@ public class ConfigParserTest {
             Assertions.assertEquals("*", url.getServiceInterface());
             Assertions.assertEquals(6666, url.getParameter(TIMEOUT_KEY, 0));
             Assertions.assertEquals("random", 
url.getParameter(LOADBALANCE_KEY));
-            Assertions.assertEquals(url.getApplication(), "demo-consumer");
+            Assertions.assertEquals("demo-consumer", url.getApplication());
         }
     }
 
@@ -145,7 +145,7 @@ public class ConfigParserTest {
             Assertions.assertEquals("*", url.getServiceInterface());
             Assertions.assertEquals(6666, url.getParameter(TIMEOUT_KEY, 0));
             Assertions.assertEquals("random", 
url.getParameter(LOADBALANCE_KEY));
-            Assertions.assertEquals(url.getApplication(), "demo-consumer");
+            Assertions.assertEquals("demo-consumer", url.getApplication());
         }
     }
 
@@ -161,7 +161,7 @@ public class ConfigParserTest {
             Assertions.assertEquals(6666, url.getParameter(TIMEOUT_KEY, 0));
             Assertions.assertEquals("random", 
url.getParameter(LOADBALANCE_KEY));
             Assertions.assertEquals("127.0.0.1:20880", 
url.getParameter(OVERRIDE_PROVIDERS_KEY));
-            Assertions.assertEquals(url.getApplication(), "demo-consumer");
+            Assertions.assertEquals("demo-consumer", url.getApplication());
         }
     }