[dubbo] branch 3.0 updated: [3.0-Triple] fix tri TheadPool is default (#10019)

[liujun]

This is an automated email from the ASF dual-hosted git repository.

liujun pushed a commit to branch 3.0
in repository https://gitbox.apache.org/repos/asf/dubbo.git


The following commit(s) were added to refs/heads/3.0 by this push:
     new b4bc7aaa66 [3.0-Triple] fix tri TheadPool is default (#10019)
b4bc7aaa66 is described below

commit b4bc7aaa664a5152c8b2cde9e50dc611ca37b9c8
Author: earthchen <earthchen1...@gmail.com>
AuthorDate: Tue May 10 10:46:28 2022 +0800

    [3.0-Triple] fix tri TheadPool is default (#10019)
---
 .../dubbo/common/threadpool/manager/ExecutorRepository.java      | 8 ++++++++
 .../org/apache/dubbo/rpc/protocol/tri/TripleHttp2Protocol.java   | 9 ++-------
 .../java/org/apache/dubbo/rpc/protocol/tri/TripleProtocol.java   | 4 ++++
 3 files changed, 14 insertions(+), 7 deletions(-)

diff --git 
a/dubbo-common/src/main/java/org/apache/dubbo/common/threadpool/manager/ExecutorRepository.java
 
b/dubbo-common/src/main/java/org/apache/dubbo/common/threadpool/manager/ExecutorRepository.java
index 3773982666..fa8026b890 100644
--- 
a/dubbo-common/src/main/java/org/apache/dubbo/common/threadpool/manager/ExecutorRepository.java
+++ 
b/dubbo-common/src/main/java/org/apache/dubbo/common/threadpool/manager/ExecutorRepository.java
@@ -38,8 +38,16 @@ public interface ExecutorRepository {
      */
     ExecutorService createExecutorIfAbsent(URL url);
 
+    /**
+     * Be careful,The semantics of this method are getOrDefaultExecutor
+     *
+     * @param url
+     * @return
+     */
     ExecutorService getExecutor(URL url);
 
+
+
     /**
      * Modify some of the threadpool's properties according to the url, for 
example, coreSize, maxSize, ...
      *
diff --git 
a/dubbo-rpc/dubbo-rpc-triple/src/main/java/org/apache/dubbo/rpc/protocol/tri/TripleHttp2Protocol.java
 
b/dubbo-rpc/dubbo-rpc-triple/src/main/java/org/apache/dubbo/rpc/protocol/tri/TripleHttp2Protocol.java
index b47e029bb5..881303f7ef 100644
--- 
a/dubbo-rpc/dubbo-rpc-triple/src/main/java/org/apache/dubbo/rpc/protocol/tri/TripleHttp2Protocol.java
+++ 
b/dubbo-rpc/dubbo-rpc-triple/src/main/java/org/apache/dubbo/rpc/protocol/tri/TripleHttp2Protocol.java
@@ -126,14 +126,9 @@ public class TripleHttp2Protocol extends Http2WireProtocol 
implements ScopeModel
 
 
     private Executor lookupExecutor(URL url) {
-        ExecutorRepository executorRepository = 
url.getOrDefaultApplicationModel()
+        return url.getOrDefaultApplicationModel()
             .getExtensionLoader(ExecutorRepository.class)
-            .getDefaultExtension();
-        Executor urlExecutor = executorRepository.getExecutor(url);
-        if (urlExecutor == null) {
-            urlExecutor = executorRepository.createExecutorIfAbsent(url);
-        }
-        return urlExecutor;
+            .getDefaultExtension().getExecutor(url);
     }
 
     @Override
diff --git 
a/dubbo-rpc/dubbo-rpc-triple/src/main/java/org/apache/dubbo/rpc/protocol/tri/TripleProtocol.java
 
b/dubbo-rpc/dubbo-rpc-triple/src/main/java/org/apache/dubbo/rpc/protocol/tri/TripleProtocol.java
index 8454250afe..91605e6bc6 100644
--- 
a/dubbo-rpc/dubbo-rpc-triple/src/main/java/org/apache/dubbo/rpc/protocol/tri/TripleProtocol.java
+++ 
b/dubbo-rpc/dubbo-rpc-triple/src/main/java/org/apache/dubbo/rpc/protocol/tri/TripleProtocol.java
@@ -120,6 +120,10 @@ public class TripleProtocol extends AbstractProtocol {
         triBuiltinService.getHealthStatusManager()
             .setStatus(url.getServiceInterface(), 
HealthCheckResponse.ServingStatus.SERVING);
 
+        // init
+        
url.getOrDefaultApplicationModel().getExtensionLoader(ExecutorRepository.class)
+            .getDefaultExtension()
+            .createExecutorIfAbsent(url);
         PortUnificationExchanger.bind(invoker.getUrl());
         return exporter;
     }