This is an automated email from the ASF dual-hosted git repository.

albumenj pushed a commit to branch 3.2
in repository https://gitbox.apache.org/repos/asf/dubbo.git


The following commit(s) were added to refs/heads/3.2 by this push:
     new 133d0061a7 remove unnecessary code (#12610)
133d0061a7 is described below

commit 133d0061a7a18a431b40ce7b688416a5f3f13a40
Author: xixingya <[email protected]>
AuthorDate: Wed Jun 28 20:34:07 2023 +0800

    remove unnecessary code (#12610)
---
 .../src/main/java/org/apache/dubbo/config/AbstractConfig.java        | 3 ---
 .../src/main/java/org/apache/dubbo/config/AbstractMethodConfig.java  | 5 +----
 dubbo-common/src/main/java/org/apache/dubbo/config/ModuleConfig.java | 3 ---
 3 files changed, 1 insertion(+), 10 deletions(-)

diff --git 
a/dubbo-common/src/main/java/org/apache/dubbo/config/AbstractConfig.java 
b/dubbo-common/src/main/java/org/apache/dubbo/config/AbstractConfig.java
index eee83f501c..75a80c8999 100644
--- a/dubbo-common/src/main/java/org/apache/dubbo/config/AbstractConfig.java
+++ b/dubbo-common/src/main/java/org/apache/dubbo/config/AbstractConfig.java
@@ -425,9 +425,6 @@ public abstract class AbstractConfig implements 
Serializable {
     }
 
     protected void checkScopeModel(ScopeModel scopeModel) {
-        if (scopeModel == null) {
-            throw new IllegalArgumentException("scopeModel cannot be null");
-        }
         if (!(scopeModel instanceof ApplicationModel)) {
             throw new IllegalArgumentException("Invalid scope model, expect to 
be a ApplicationModel but got: " + scopeModel);
         }
diff --git 
a/dubbo-common/src/main/java/org/apache/dubbo/config/AbstractMethodConfig.java 
b/dubbo-common/src/main/java/org/apache/dubbo/config/AbstractMethodConfig.java
index ca8d15c68a..f0367c6c5d 100644
--- 
a/dubbo-common/src/main/java/org/apache/dubbo/config/AbstractMethodConfig.java
+++ 
b/dubbo-common/src/main/java/org/apache/dubbo/config/AbstractMethodConfig.java
@@ -103,7 +103,7 @@ public abstract class AbstractMethodConfig extends 
AbstractConfig {
     protected Integer forks;
 
     public AbstractMethodConfig() {
-        super();
+
     }
 
     public AbstractMethodConfig(ModuleModel moduleModel) {
@@ -124,9 +124,6 @@ public abstract class AbstractMethodConfig extends 
AbstractConfig {
 
     @Override
     protected void checkScopeModel(ScopeModel scopeModel) {
-        if (scopeModel == null) {
-            throw new IllegalArgumentException("scopeModel cannot be null");
-        }
         if (!(scopeModel instanceof ModuleModel)) {
             throw new IllegalArgumentException("Invalid scope model, expect to 
be a ModuleModel but got: " + scopeModel);
         }
diff --git 
a/dubbo-common/src/main/java/org/apache/dubbo/config/ModuleConfig.java 
b/dubbo-common/src/main/java/org/apache/dubbo/config/ModuleConfig.java
index ef6eaf870d..859d6678e4 100644
--- a/dubbo-common/src/main/java/org/apache/dubbo/config/ModuleConfig.java
+++ b/dubbo-common/src/main/java/org/apache/dubbo/config/ModuleConfig.java
@@ -127,9 +127,6 @@ public class ModuleConfig extends AbstractConfig {
 
     @Override
     protected void checkScopeModel(ScopeModel scopeModel) {
-        if (scopeModel == null) {
-            throw new IllegalArgumentException("scopeModel cannot be null");
-        }
         if (!(scopeModel instanceof ModuleModel)) {
             throw new IllegalArgumentException("Invalid scope model, expect to 
be a ModuleModel but got: " + scopeModel);
         }

Reply via email to