This is an automated email from the ASF dual-hosted git repository.
albumenj pushed a commit to branch 3.2
in repository https://gitbox.apache.org/repos/asf/dubbo.git
The following commit(s) were added to refs/heads/3.2 by this push:
new 966efaab85 do not invoke test method(#13589) (#13601)
966efaab85 is described below
commit 966efaab85a30d3d9339093381a7b069c2d71c64
Author: MaruHibiki <[email protected]>
AuthorDate: Wed Jan 10 11:27:48 2024 +0800
do not invoke test method(#13589) (#13601)
* do not invoke test method(#13589)
* Fix style check
---------
Co-authored-by: Albumen Kevin <[email protected]>
---
.../src/main/java/org/apache/dubbo/rpc/filter/ExceptionFilter.java | 4 +++-
.../test/java/org/apache/dubbo/rpc/filter/ExceptionFilterTest.java | 2 +-
2 files changed, 4 insertions(+), 2 deletions(-)
diff --git
a/dubbo-rpc/dubbo-rpc-api/src/main/java/org/apache/dubbo/rpc/filter/ExceptionFilter.java
b/dubbo-rpc/dubbo-rpc-api/src/main/java/org/apache/dubbo/rpc/filter/ExceptionFilter.java
index 0fc159967a..e213cc9d2a 100644
---
a/dubbo-rpc/dubbo-rpc-api/src/main/java/org/apache/dubbo/rpc/filter/ExceptionFilter.java
+++
b/dubbo-rpc/dubbo-rpc-api/src/main/java/org/apache/dubbo/rpc/filter/ExceptionFilter.java
@@ -18,6 +18,7 @@ package org.apache.dubbo.rpc.filter;
import org.apache.dubbo.common.constants.CommonConstants;
import org.apache.dubbo.common.extension.Activate;
+import org.apache.dubbo.common.extension.DisableInject;
import org.apache.dubbo.common.logger.ErrorTypeAwareLogger;
import org.apache.dubbo.common.logger.LoggerFactory;
import org.apache.dubbo.common.utils.ReflectUtils;
@@ -140,7 +141,8 @@ public class ExceptionFilter implements Filter,
Filter.Listener {
}
// For test purpose
- public void setLogger(ErrorTypeAwareLogger logger) {
+ @DisableInject
+ public void mockLogger(ErrorTypeAwareLogger logger) {
this.logger = logger;
}
}
diff --git
a/dubbo-rpc/dubbo-rpc-api/src/test/java/org/apache/dubbo/rpc/filter/ExceptionFilterTest.java
b/dubbo-rpc/dubbo-rpc-api/src/test/java/org/apache/dubbo/rpc/filter/ExceptionFilterTest.java
index 76c964d8cf..6a5d6ad417 100644
---
a/dubbo-rpc/dubbo-rpc-api/src/test/java/org/apache/dubbo/rpc/filter/ExceptionFilterTest.java
+++
b/dubbo-rpc/dubbo-rpc-api/src/test/java/org/apache/dubbo/rpc/filter/ExceptionFilterTest.java
@@ -63,7 +63,7 @@ class ExceptionFilterTest {
exceptionFilter.invoke(invoker, invocation);
} catch (RpcException e) {
assertEquals("TestRpcException", e.getMessage());
- exceptionFilter.setLogger(failsafeLogger);
+ exceptionFilter.mockLogger(failsafeLogger);
exceptionFilter.onError(e, invoker, invocation);
}