This is an automated email from the ASF dual-hosted git repository.

hufeng pushed a commit to branch dubbo2
in repository https://gitbox.apache.org/repos/asf/dubbo-js.git


The following commit(s) were added to refs/heads/dubbo2 by this push:
     new b9ef4ab  fixed group and version match rule
b9ef4ab is described below

commit b9ef4ab74aa4503320afbc65e72333f355c0ca5c
Author: 胡锋 <[email protected]>
AuthorDate: Thu Jan 25 17:18:48 2024 +0800

    fixed group and version match rule
---
 .../src/dubbo-transport/dubbo-transport-manager.ts          | 13 ++++++-------
 1 file changed, 6 insertions(+), 7 deletions(-)

diff --git 
a/packages/dubbo-consumer/src/dubbo-transport/dubbo-transport-manager.ts 
b/packages/dubbo-consumer/src/dubbo-transport/dubbo-transport-manager.ts
index 23c8768..57780ad 100644
--- a/packages/dubbo-consumer/src/dubbo-transport/dubbo-transport-manager.ts
+++ b/packages/dubbo-consumer/src/dubbo-transport/dubbo-transport-manager.ts
@@ -222,13 +222,12 @@ export default class DubboTransportManager extends 
EventEmitter {
     return this.dubboServiceMap
       .get(dubboInterface)
       .filter((url) => {
-        // "*" refer to default wildcard in dubbo
-        const isSameVersion =
-          !version || version === '*' || url.version === version
-        //如果Group为null,就默认匹配, 不检查group
-        //如果Group不为null,确保group和接口的group一致
-        const isSameGroup = !group || group === url.group
-        return isSameGroup && isSameVersion
+          // "*" refer to default wildcard in dubbo
+          const isSameVersion = version === '*' || url.version === version
+          //如果Group为null,就默认匹配, 不检查group
+          //如果Group不为null,确保group和接口的group一致
+          const isSameGroup = group === '*' || group === url.group
+          return isSameGroup && isSameVersion
       })
       .reduce((reducer: Set<HostName>, prop: DubboUrl) => {
         reducer.add(prop.hostname)

Reply via email to