This is an automated email from the ASF dual-hosted git repository.

alexstocks pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/dubbo-go.git


The following commit(s) were added to refs/heads/main by this push:
     new 104fae2fb fix: fix miss makezero bug (#2682)
104fae2fb is described below

commit 104fae2fbe36fd7f4420caae809c6436c1d76a6b
Author: alingse <[email protected]>
AuthorDate: Thu May 30 13:36:20 2024 +0800

    fix: fix miss makezero bug (#2682)
    
    Signed-off-by: alingse <[email protected]>
---
 protocol/dubbo3/dubbo3_protocol.go                                   | 2 +-
 registry/servicediscovery/service_instances_changed_listener_impl.go | 2 +-
 xds/client/resource/filter_chain.go                                  | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/protocol/dubbo3/dubbo3_protocol.go 
b/protocol/dubbo3/dubbo3_protocol.go
index c3b6e7f4a..7beb5e5fd 100644
--- a/protocol/dubbo3/dubbo3_protocol.go
+++ b/protocol/dubbo3/dubbo3_protocol.go
@@ -147,7 +147,7 @@ func (dp *DubboProtocol) Refer(url *common.URL) 
protocol.Invoker {
 // Destroy destroy dubbo3 service.
 func (dp *DubboProtocol) Destroy() {
        dp.BaseProtocol.Destroy()
-       keyList := make([]string, 16)
+       keyList := make([]string, 0, 16)
 
        dp.serverLock.Lock()
        defer dp.serverLock.Unlock()
diff --git 
a/registry/servicediscovery/service_instances_changed_listener_impl.go 
b/registry/servicediscovery/service_instances_changed_listener_impl.go
index ea21510b2..8799cb055 100644
--- a/registry/servicediscovery/service_instances_changed_listener_impl.go
+++ b/registry/servicediscovery/service_instances_changed_listener_impl.go
@@ -114,7 +114,7 @@ func (lstn *ServiceInstancesChangedListenerImpl) OnEvent(e 
observer.Event) error
                        }
                        subInstances := revisionToInstances[revision]
                        if subInstances == nil {
-                               subInstances = make([]registry.ServiceInstance, 
8)
+                               subInstances = make([]registry.ServiceInstance, 
0, 8)
                        }
                        revisionToInstances[revision] = append(subInstances, 
instance)
                        metadataInfo := lstn.revisionToMetadata[revision]
diff --git a/xds/client/resource/filter_chain.go 
b/xds/client/resource/filter_chain.go
index 5a44b4928..d9c6141c6 100644
--- a/xds/client/resource/filter_chain.go
+++ b/xds/client/resource/filter_chain.go
@@ -110,7 +110,7 @@ type RouteWithInterceptors struct {
 // ConstructUsableRouteConfiguration takes Route Configuration and converts it
 // into matchable route configuration, with instantiated HTTP Filters per 
route.
 func (f *FilterChain) ConstructUsableRouteConfiguration(config 
RouteConfigUpdate) ([]VirtualHostWithInterceptors, error) {
-       vhs := make([]VirtualHostWithInterceptors, len(config.VirtualHosts))
+       vhs := make([]VirtualHostWithInterceptors, 0, len(config.VirtualHosts))
        for _, vh := range config.VirtualHosts {
                vhwi, err := f.convertVirtualHost(vh)
                if err != nil {

Reply via email to