This is an automated email from the ASF dual-hosted git repository.

albumenj pushed a commit to branch 3.2
in repository https://gitbox.apache.org/repos/asf/dubbo.git


The following commit(s) were added to refs/heads/3.2 by this push:
     new d35d7eb30c fix: Disable accesslog while the config is false (#14257)
d35d7eb30c is described below

commit d35d7eb30c9e536bead96d50d45ff6def219f84f
Author: aofall <[email protected]>
AuthorDate: Fri May 31 15:05:16 2024 +0800

    fix: Disable accesslog while the config is false (#14257)
---
 .../src/main/java/org/apache/dubbo/rpc/filter/AccessLogFilter.java      | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git 
a/dubbo-rpc/dubbo-rpc-api/src/main/java/org/apache/dubbo/rpc/filter/AccessLogFilter.java
 
b/dubbo-rpc/dubbo-rpc-api/src/main/java/org/apache/dubbo/rpc/filter/AccessLogFilter.java
index 1469630781..d0b0b4b392 100644
--- 
a/dubbo-rpc/dubbo-rpc-api/src/main/java/org/apache/dubbo/rpc/filter/AccessLogFilter.java
+++ 
b/dubbo-rpc/dubbo-rpc-api/src/main/java/org/apache/dubbo/rpc/filter/AccessLogFilter.java
@@ -108,7 +108,7 @@ public class AccessLogFilter implements Filter {
     public Result invoke(Invoker<?> invoker, Invocation inv) throws 
RpcException {
         String accessLogKey = 
invoker.getUrl().getParameter(Constants.ACCESS_LOG_KEY);
         boolean isFixedPath = 
invoker.getUrl().getParameter(ACCESS_LOG_FIXED_PATH_KEY, true);
-        if (StringUtils.isEmpty(accessLogKey)) {
+        if (StringUtils.isEmpty(accessLogKey) || 
"false".equalsIgnoreCase(accessLogKey)) {
             // Notice that disable accesslog of one service may cause the 
whole application to stop collecting
             // accesslog.
             // It's recommended to use application level configuration to 
enable or disable accesslog if dynamically

Reply via email to