(dubbo) branch 3.3 updated: fix: Remove invalid parameters (#14507)

[albumenj]

This is an automated email from the ASF dual-hosted git repository.

albumenj pushed a commit to branch 3.3
in repository https://gitbox.apache.org/repos/asf/dubbo.git


The following commit(s) were added to refs/heads/3.3 by this push:
     new 4febe492ea fix: Remove invalid parameters (#14507)
4febe492ea is described below

commit 4febe492eaa57e58b92bb27b42144ac7bea772a9
Author: Zaki <91261012+cnza...@users.noreply.github.com>
AuthorDate: Mon Aug 12 09:53:36 2024 +0800

    fix: Remove invalid parameters (#14507)
    
    Co-authored-by: Albumen Kevin <jhq0...@gmail.com>
---
 .../java/org/apache/dubbo/rpc/protocol/tri/call/TripleClientCall.java  | 2 +-
 .../dubbo/rpc/protocol/tri/stream/AbstractTripleClientStream.java      | 2 +-
 .../java/org/apache/dubbo/rpc/protocol/tri/stream/ClientStream.java    | 3 +--
 .../apache/dubbo/rpc/protocol/tri/stream/TripleClientStreamTest.java   | 2 +-
 4 files changed, 4 insertions(+), 5 deletions(-)

diff --git 
a/dubbo-rpc/dubbo-rpc-triple/src/main/java/org/apache/dubbo/rpc/protocol/tri/call/TripleClientCall.java
 
b/dubbo-rpc/dubbo-rpc-triple/src/main/java/org/apache/dubbo/rpc/protocol/tri/call/TripleClientCall.java
index 877fcd09d7..24b80585a8 100644
--- 
a/dubbo-rpc/dubbo-rpc-triple/src/main/java/org/apache/dubbo/rpc/protocol/tri/call/TripleClientCall.java
+++ 
b/dubbo-rpc/dubbo-rpc-triple/src/main/java/org/apache/dubbo/rpc/protocol/tri/call/TripleClientCall.java
@@ -191,7 +191,7 @@ public class TripleClientCall implements ClientCall, 
ClientStream.Listener {
             data = requestMetadata.packableMethod.packRequest(message);
             int compressed = 
Identity.MESSAGE_ENCODING.equals(requestMetadata.compressor.getMessageEncoding())
 ? 0 : 1;
             final byte[] compress = requestMetadata.compressor.compress(data);
-            stream.sendMessage(compress, compressed, false).addListener(f -> {
+            stream.sendMessage(compress, compressed).addListener(f -> {
                 if (!f.isSuccess()) {
                     cancelByLocal(f.cause());
                 }
diff --git 
a/dubbo-rpc/dubbo-rpc-triple/src/main/java/org/apache/dubbo/rpc/protocol/tri/stream/AbstractTripleClientStream.java
 
b/dubbo-rpc/dubbo-rpc-triple/src/main/java/org/apache/dubbo/rpc/protocol/tri/stream/AbstractTripleClientStream.java
index e1fdd0f14a..7ceea89e60 100644
--- 
a/dubbo-rpc/dubbo-rpc-triple/src/main/java/org/apache/dubbo/rpc/protocol/tri/stream/AbstractTripleClientStream.java
+++ 
b/dubbo-rpc/dubbo-rpc-triple/src/main/java/org/apache/dubbo/rpc/protocol/tri/stream/AbstractTripleClientStream.java
@@ -146,7 +146,7 @@ public abstract class AbstractTripleClientStream extends 
AbstractStream implemen
     }
 
     @Override
-    public ChannelFuture sendMessage(byte[] message, int compressFlag, boolean 
eos) {
+    public ChannelFuture sendMessage(byte[] message, int compressFlag) {
         ChannelFuture checkResult = preCheck();
         if (!checkResult.isSuccess()) {
             return checkResult;
diff --git 
a/dubbo-rpc/dubbo-rpc-triple/src/main/java/org/apache/dubbo/rpc/protocol/tri/stream/ClientStream.java
 
b/dubbo-rpc/dubbo-rpc-triple/src/main/java/org/apache/dubbo/rpc/protocol/tri/stream/ClientStream.java
index 304d3c4653..4f9f8c8b9b 100644
--- 
a/dubbo-rpc/dubbo-rpc-triple/src/main/java/org/apache/dubbo/rpc/protocol/tri/stream/ClientStream.java
+++ 
b/dubbo-rpc/dubbo-rpc-triple/src/main/java/org/apache/dubbo/rpc/protocol/tri/stream/ClientStream.java
@@ -62,10 +62,9 @@ public interface ClientStream extends Stream {
      * Send message to remote peer.
      *
      * @param message message to send to remote peer
-     * @param eos     whether this is the last message
      * @return future to callback when send message is done
      */
-    Future<?> sendMessage(byte[] message, int compressFlag, boolean eos);
+    Future<?> sendMessage(byte[] message, int compressFlag);
 
     /**
      * No more data will be sent, half close this stream to wait server 
response.
diff --git 
a/dubbo-rpc/dubbo-rpc-triple/src/test/java/org/apache/dubbo/rpc/protocol/tri/stream/TripleClientStreamTest.java
 
b/dubbo-rpc/dubbo-rpc-triple/src/test/java/org/apache/dubbo/rpc/protocol/tri/stream/TripleClientStreamTest.java
index d3d16c9946..1f8522305d 100644
--- 
a/dubbo-rpc/dubbo-rpc-triple/src/test/java/org/apache/dubbo/rpc/protocol/tri/stream/TripleClientStreamTest.java
+++ 
b/dubbo-rpc/dubbo-rpc-triple/src/test/java/org/apache/dubbo/rpc/protocol/tri/stream/TripleClientStreamTest.java
@@ -100,7 +100,7 @@ class TripleClientStreamTest {
         verify(writeQueue).enqueueFuture(any(HeaderQueueCommand.class), 
any(Executor.class));
         // no other commands
         verify(writeQueue).enqueue(any(QueuedCommand.class));
-        stream.sendMessage(new byte[0], 0, false);
+        stream.sendMessage(new byte[0], 0);
         verify(writeQueue).enqueueFuture(any(DataQueueCommand.class), 
any(Executor.class));
         verify(writeQueue, times(2)).enqueueFuture(any(QueuedCommand.class), 
any(Executor.class));
         stream.halfClose();