This is an automated email from the ASF dual-hosted git repository.

albumenj pushed a commit to branch 3.3
in repository https://gitbox.apache.org/repos/asf/dubbo-spi-extensions.git


The following commit(s) were added to refs/heads/3.3 by this push:
     new cbc65a49 `listeners.get(msg).isEmpty()` Null pointer reported an error 
(#463)
cbc65a49 is described below

commit cbc65a49b3297543eb1f253def2c61375f9a4625
Author: CrazyLionLi <[email protected]>
AuthorDate: Wed Aug 21 09:45:48 2024 +0800

    `listeners.get(msg).isEmpty()` Null pointer reported an error (#463)
    
    * Update RedisMetadataReport.java
    
    `listeners.get(msg).isEmpty()` Null pointer reported an error
    
    * Update RedisMetadataReport.java
    
    Use tool class optimization
---
 .../org/apache/dubbo/metadata/store/redis/RedisMetadataReport.java     | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git 
a/dubbo-metadata-report-extensions/dubbo-metadata-report-redis/src/main/java/org/apache/dubbo/metadata/store/redis/RedisMetadataReport.java
 
b/dubbo-metadata-report-extensions/dubbo-metadata-report-redis/src/main/java/org/apache/dubbo/metadata/store/redis/RedisMetadataReport.java
index 1c010f07..3ecdab15 100644
--- 
a/dubbo-metadata-report-extensions/dubbo-metadata-report-redis/src/main/java/org/apache/dubbo/metadata/store/redis/RedisMetadataReport.java
+++ 
b/dubbo-metadata-report-extensions/dubbo-metadata-report-redis/src/main/java/org/apache/dubbo/metadata/store/redis/RedisMetadataReport.java
@@ -24,6 +24,7 @@ import org.apache.dubbo.common.utils.ConcurrentHashMapUtils;
 import org.apache.dubbo.common.utils.ConcurrentHashSet;
 import org.apache.dubbo.common.utils.JsonUtils;
 import org.apache.dubbo.common.utils.StringUtils;
+import org.apache.dubbo.common.utils.CollectionUtils;
 import org.apache.dubbo.metadata.MappingChangedEvent;
 import org.apache.dubbo.metadata.MappingListener;
 import org.apache.dubbo.metadata.MetadataInfo;
@@ -481,7 +482,7 @@ public class RedisMetadataReport extends 
AbstractMetadataReport {
             logger.info("sub from redis:" + key + " message:" + msg);
             String applicationNames = 
getMappingData(buildMappingKey(DEFAULT_MAPPING_GROUP), msg);
             MappingChangedEvent mappingChangedEvent = new 
MappingChangedEvent(msg, getAppNames(applicationNames));
-            if (!listeners.get(msg).isEmpty()) {
+            if (!CollectionUtils.isEmpty(listeners.get(msg))) {
                 for (MappingListener mappingListener : listeners.get(msg)) {
                     mappingListener.onEvent(mappingChangedEvent);
                 }

Reply via email to