This is an automated email from the ASF dual-hosted git repository.

albumenj pushed a commit to branch 3.3
in repository https://gitbox.apache.org/repos/asf/dubbo.git


The following commit(s) were added to refs/heads/3.3 by this push:
     new 953483abf5 Simplify auth failed message (#14801)
953483abf5 is described below

commit 953483abf5bbb6ca076097647146abd8f667eb67
Author: Albumen Kevin <[email protected]>
AuthorDate: Thu Oct 24 16:40:35 2024 +0800

    Simplify auth failed message (#14801)
    
    * Simplify auth failed message
    
    * Fix style
---
 .../java/org/apache/dubbo/auth/AccessKeyAuthenticator.java     |  4 ++--
 .../org/apache/dubbo/auth/filter/ProviderAuthHeaderFilter.java | 10 +---------
 2 files changed, 3 insertions(+), 11 deletions(-)

diff --git 
a/dubbo-plugin/dubbo-auth/src/main/java/org/apache/dubbo/auth/AccessKeyAuthenticator.java
 
b/dubbo-plugin/dubbo-auth/src/main/java/org/apache/dubbo/auth/AccessKeyAuthenticator.java
index ce5d20aff9..173abe16c4 100644
--- 
a/dubbo-plugin/dubbo-auth/src/main/java/org/apache/dubbo/auth/AccessKeyAuthenticator.java
+++ 
b/dubbo-plugin/dubbo-auth/src/main/java/org/apache/dubbo/auth/AccessKeyAuthenticator.java
@@ -62,7 +62,7 @@ public class AccessKeyAuthenticator implements Authenticator {
         try {
             accessKeyPair = getAccessKeyPair(invocation, url);
         } catch (Exception e) {
-            throw new RpcAuthenticationException("Failed to authenticate , 
can't load the accessKeyPair", e);
+            throw new RpcAuthenticationException("Failed to authenticate , 
can't load the accessKeyPair");
         }
 
         String computeSignature = getSignature(url, invocation, 
accessKeyPair.getSecretKey(), requestTimestamp);
@@ -85,7 +85,7 @@ public class AccessKeyAuthenticator implements Authenticator {
                 throw new AccessKeyNotFoundException("AccessKeyId or 
secretAccessKey not found");
             }
         } catch (Exception e) {
-            throw new RuntimeException("Can't load the AccessKeyPair from 
accessKeyStorage", e);
+            throw new RuntimeException("Can't load the AccessKeyPair from 
accessKeyStorage");
         }
         return accessKeyPair;
     }
diff --git 
a/dubbo-plugin/dubbo-auth/src/main/java/org/apache/dubbo/auth/filter/ProviderAuthHeaderFilter.java
 
b/dubbo-plugin/dubbo-auth/src/main/java/org/apache/dubbo/auth/filter/ProviderAuthHeaderFilter.java
index 2477e25d5b..45364ebbeb 100644
--- 
a/dubbo-plugin/dubbo-auth/src/main/java/org/apache/dubbo/auth/filter/ProviderAuthHeaderFilter.java
+++ 
b/dubbo-plugin/dubbo-auth/src/main/java/org/apache/dubbo/auth/filter/ProviderAuthHeaderFilter.java
@@ -22,11 +22,9 @@ import org.apache.dubbo.common.URL;
 import org.apache.dubbo.common.extension.Activate;
 import org.apache.dubbo.rpc.HeaderFilter;
 import org.apache.dubbo.rpc.Invoker;
-import org.apache.dubbo.rpc.RpcContext;
 import org.apache.dubbo.rpc.RpcException;
 import org.apache.dubbo.rpc.RpcInvocation;
 import org.apache.dubbo.rpc.model.FrameworkModel;
-import org.apache.dubbo.rpc.support.RpcUtils;
 
 import static org.apache.dubbo.rpc.RpcException.AUTHORIZATION_EXCEPTION;
 
@@ -49,13 +47,7 @@ public class ProviderAuthHeaderFilter implements 
HeaderFilter {
             try {
                 authenticator.authenticate(invocation, url);
             } catch (Exception e) {
-                Class<?> serviceType = invoker.getInterface();
-                throw new RpcException(
-                        AUTHORIZATION_EXCEPTION,
-                        "Forbid invoke remote service " + serviceType + " 
method " + RpcUtils.getMethodName(invocation)
-                                + "() from consumer "
-                                + 
invocation.getAttributes().get(Constants.REMOTE_ADDRESS_KEY) + " to provider "
-                                + 
RpcContext.getServiceContext().getLocalHost());
+                throw new RpcException(AUTHORIZATION_EXCEPTION, "No Auth.");
             }
             invocation.getAttributes().put(Constants.AUTH_SUCCESS, 
Boolean.TRUE);
         }

Reply via email to