This is an automated email from the ASF dual-hosted git repository.
zhongxjian pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/dubbo-kubernetes.git
The following commit(s) were added to refs/heads/master by this push:
new 430b61ae [dubboctl] fix errors
430b61ae is described below
commit 430b61ae45fd2b951579e9bc855fc4320555d61e
Author: mfordjody <[email protected]>
AuthorDate: Wed Oct 30 10:19:53 2024 +0800
[dubboctl] fix errors
---
dubboctl/pkg/deploy/create_test.go | 136 -------------------------------------
1 file changed, 136 deletions(-)
diff --git a/dubboctl/pkg/deploy/create_test.go
b/dubboctl/pkg/deploy/create_test.go
deleted file mode 100644
index abae84b7..00000000
--- a/dubboctl/pkg/deploy/create_test.go
+++ /dev/null
@@ -1,136 +0,0 @@
-// Licensed to the Apache Software Foundation (ASF) under one or more
-// contributor license agreements. See the NOTICE file distributed with
-// this work for additional information regarding copyright ownership.
-// The ASF licenses this file to You under the Apache License, Version 2.0
-// (the "License"); you may not use this file except in compliance with
-// the License. You may obtain a copy of the License at
-//
-// http://www.apache.org/licenses/LICENSE-2.0
-//
-// Unless required by applicable law or agreed to in writing, software
-// distributed under the License is distributed on an "AS IS" BASIS,
-// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-// See the License for the specific language governing permissions and
-// limitations under the License.
-
-package deploy
-
-import (
- "errors"
- "github.com/apache/dubbo-kubernetes/dubboctl/cmd"
- "testing"
-)
-
-import (
- "github.com/ory/viper"
-)
-
-import (
- . "github.com/apache/dubbo-kubernetes/dubboctl/internal/testing"
-)
-
-import (
- "github.com/apache/dubbo-kubernetes/dubboctl/internal/util"
-)
-
-// TestCreate_Execute ensures that an invocation of create with minimal
settings
-// and valid input completes without error; degenerate case.
-func TestCreate_Execute(t *testing.T) {
- _ = FromTempDirectory(t)
-
- cmds := cmd.GetRootCmd([]string{"create", "--language", "go", "myfunc"})
-
- if err := cmds.Execute(); err != nil {
- t.Fatal(err)
- }
-}
-
-// TestCreate_NoRuntime ensures that an invocation of create must be
-// done with a runtime.
-func TestCreate_NoRuntime(t *testing.T) {
- _ = FromTempDirectory(t)
-
- cmds := cmd.GetRootCmd([]string{"create", "myfunc"})
-
- err := cmds.Execute()
- var e ErrNoRuntime
- if !errors.As(err, &e) {
- t.Fatalf("Did not receive ErrNoRuntime. Got %v", err)
- }
-}
-
-// TestCreate_WithNoRuntime ensures that an invocation of create must be
-// done with one of the valid runtimes only.
-func TestCreate_WithInvalidRuntime(t *testing.T) {
- _ = FromTempDirectory(t)
-
- cmds := cmd.GetRootCmd([]string{"create", "--language", "invalid",
"myfunc"})
-
- err := cmds.Execute()
- var e ErrInvalidRuntime
- if !errors.As(err, &e) {
- t.Fatalf("Did not receive ErrInvalidRuntime. Got %v", err)
- }
-}
-
-// TestCreate_InvalidTemplate ensures that an invocation of create must be
-// done with one of the valid templates only.
-func TestCreate_InvalidTemplate(t *testing.T) {
- _ = FromTempDirectory(t)
-
- cmds := cmd.GetRootCmd([]string{"create", "--language", "go",
"--template", "invalid", "myfunc"})
-
- err := cmds.Execute()
- var e ErrInvalidTemplate
- if !errors.As(err, &e) {
- t.Fatalf("Did not receive ErrInvalidTemplate. Got %v", err)
- }
-}
-
-// TestCreate_ValidatesName ensures that the create command only accepts
-// DNS-1123 labels for function name.
-func TestCreate_ValidatesName(t *testing.T) {
- _ = FromTempDirectory(t)
-
- // Execute the command with a function name containing invalid
characters and
- // confirm the expected error is returned
- cmds := cmd.GetRootCmd([]string{"create", "invalid!"})
- err := cmds.Execute()
- var e util.ErrInvalidApplicationName
- if !errors.As(err, &e) {
- t.Fatalf("Did not receive ErrInvalidApplicationName. Got %v",
err)
- }
-}
-
-// TestCreate_ConfigOptional ensures that the system can be used without
-// any additional configuration being required.
-func TestCreate_ConfigOptional(t *testing.T) {
- _ = FromTempDirectory(t)
-
- t.Setenv("XDG_CONFIG_HOME", t.TempDir())
-
- cmds := cmd.GetRootCmd([]string{"create", "--language=go", "myfunc"})
- if err := cmds.Execute(); err != nil {
- t.Fatal(err)
- }
-
- // Not failing is success. Config files or settings beyond what are
- // automatically written to to the given config home are currently
optional.
-}
-
-// FromTempDirectory is a test helper which endeavors to create
-// an environment clean of developer's settings for use during CLI testing.
-func FromTempDirectory(t *testing.T) string {
- t.Helper()
- ClearEnvs(t)
-
- // By default unit tests presume no config exists unless provided in
testdata.
- t.Setenv("XDG_CONFIG_HOME", t.TempDir())
-
- // creates and CDs to a temp directory
- d, done := Mktemp(t)
-
- // Return to original directory and resets viper.
- t.Cleanup(func() { done(); viper.Reset() })
- return d
-}
\ No newline at end of file
