(dubbo-kubernetes) branch master updated: [dubboctl] Modifying test content

[zhongxjian]

This is an automated email from the ASF dual-hosted git repository.

zhongxjian pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/dubbo-kubernetes.git


The following commit(s) were added to refs/heads/master by this push:
     new 31759895 [dubboctl] Modifying test content
31759895 is described below

commit 31759895d1d6d7c28303adcb1c19a71e3d7effa1
Author: mfordjody <11638...@qq.com>
AuthorDate: Wed Oct 30 10:27:05 2024 +0800

    [dubboctl] Modifying test content
---
 dubboctl/pkg/deploy/create_test.go     | 27 ++++++++++++++-------------
 dubboctl/pkg/deploy/repository_test.go |  2 +-
 2 files changed, 15 insertions(+), 14 deletions(-)

diff --git a/dubboctl/pkg/deploy/create_test.go 
b/dubboctl/pkg/deploy/create_test.go
index abae84b7..bed8ba05 100644
--- a/dubboctl/pkg/deploy/create_test.go
+++ b/dubboctl/pkg/deploy/create_test.go
@@ -13,11 +13,12 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-package deploy
+package deploy_test
 
 import (
        "errors"
        "github.com/apache/dubbo-kubernetes/dubboctl/cmd"
+       "github.com/apache/dubbo-kubernetes/dubboctl/pkg/deploy"
        "testing"
 )
 
@@ -36,7 +37,7 @@ import (
 // TestCreate_Execute ensures that an invocation of create with minimal 
settings
 // and valid input completes without error; degenerate case.
 func TestCreate_Execute(t *testing.T) {
-       _ = FromTempDirectory(t)
+       _ = fromTempDirectory(t)
 
        cmds := cmd.GetRootCmd([]string{"create", "--language", "go", "myfunc"})
 
@@ -48,12 +49,12 @@ func TestCreate_Execute(t *testing.T) {
 // TestCreate_NoRuntime ensures that an invocation of create must be
 // done with a runtime.
 func TestCreate_NoRuntime(t *testing.T) {
-       _ = FromTempDirectory(t)
+       _ = fromTempDirectory(t)
 
        cmds := cmd.GetRootCmd([]string{"create", "myfunc"})
 
        err := cmds.Execute()
-       var e ErrNoRuntime
+       var e deploy.ErrNoRuntime
        if !errors.As(err, &e) {
                t.Fatalf("Did not receive ErrNoRuntime. Got %v", err)
        }
@@ -62,12 +63,12 @@ func TestCreate_NoRuntime(t *testing.T) {
 // TestCreate_WithNoRuntime ensures that an invocation of create must be
 // done with one of the valid runtimes only.
 func TestCreate_WithInvalidRuntime(t *testing.T) {
-       _ = FromTempDirectory(t)
+       _ = fromTempDirectory(t)
 
        cmds := cmd.GetRootCmd([]string{"create", "--language", "invalid", 
"myfunc"})
 
        err := cmds.Execute()
-       var e ErrInvalidRuntime
+       var e deploy.ErrInvalidRuntime
        if !errors.As(err, &e) {
                t.Fatalf("Did not receive ErrInvalidRuntime. Got %v", err)
        }
@@ -76,12 +77,12 @@ func TestCreate_WithInvalidRuntime(t *testing.T) {
 // TestCreate_InvalidTemplate ensures that an invocation of create must be
 // done with one of the valid templates only.
 func TestCreate_InvalidTemplate(t *testing.T) {
-       _ = FromTempDirectory(t)
+       _ = fromTempDirectory(t)
 
        cmds := cmd.GetRootCmd([]string{"create", "--language", "go", 
"--template", "invalid", "myfunc"})
 
        err := cmds.Execute()
-       var e ErrInvalidTemplate
+       var e deploy.ErrInvalidTemplate
        if !errors.As(err, &e) {
                t.Fatalf("Did not receive ErrInvalidTemplate. Got %v", err)
        }
@@ -90,7 +91,7 @@ func TestCreate_InvalidTemplate(t *testing.T) {
 // TestCreate_ValidatesName ensures that the create command only accepts
 // DNS-1123 labels for function name.
 func TestCreate_ValidatesName(t *testing.T) {
-       _ = FromTempDirectory(t)
+       _ = fromTempDirectory(t)
 
        // Execute the command with a function name containing invalid 
characters and
        // confirm the expected error is returned
@@ -105,7 +106,7 @@ func TestCreate_ValidatesName(t *testing.T) {
 // TestCreate_ConfigOptional ensures that the system can be used without
 // any additional configuration being required.
 func TestCreate_ConfigOptional(t *testing.T) {
-       _ = FromTempDirectory(t)
+       _ = fromTempDirectory(t)
 
        t.Setenv("XDG_CONFIG_HOME", t.TempDir())
 
@@ -118,9 +119,9 @@ func TestCreate_ConfigOptional(t *testing.T) {
        // automatically written to to the given config home are currently 
optional.
 }
 
-// FromTempDirectory is a test helper which endeavors to create
+// fromTempDirectory is a test helper which endeavors to create
 // an environment clean of developer's settings for use during CLI testing.
-func FromTempDirectory(t *testing.T) string {
+func fromTempDirectory(t *testing.T) string {
        t.Helper()
        ClearEnvs(t)
 
@@ -133,4 +134,4 @@ func FromTempDirectory(t *testing.T) string {
        // Return to original directory and resets viper.
        t.Cleanup(func() { done(); viper.Reset() })
        return d
-}
\ No newline at end of file
+}
diff --git a/dubboctl/pkg/deploy/repository_test.go 
b/dubboctl/pkg/deploy/repository_test.go
index e0deb9e9..1c488ea3 100644
--- a/dubboctl/pkg/deploy/repository_test.go
+++ b/dubboctl/pkg/deploy/repository_test.go
@@ -87,7 +87,7 @@ func piped(t *testing.T) func() string {
        }
 }
 
-// FromTempDirectory is a test helper which endeavors to create
+// fromTempDirectory is a test helper which endeavors to create
 // an environment clean of developer's settings for use during CLI testing.
 func FromTempDirectory(t *testing.T) string {
        t.Helper()