This is an automated email from the ASF dual-hosted git repository.
zhongxjian pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/dubbo-kubernetes.git
The following commit(s) were added to refs/heads/master by this push:
new 4092e8f0 [operator] update uninstall logic
4092e8f0 is described below
commit 4092e8f058ae310ca71099029706e0e1a7c44735
Author: mfordjody <[email protected]>
AuthorDate: Mon Dec 23 09:36:27 2024 +0800
[operator] update uninstall logic
---
operator/cmd/cluster/uninstall.go | 5 ++++-
operator/pkg/component/component.go | 2 +-
2 files changed, 5 insertions(+), 2 deletions(-)
diff --git a/operator/cmd/cluster/uninstall.go
b/operator/cmd/cluster/uninstall.go
index 4d3c9d30..18009a61 100644
--- a/operator/cmd/cluster/uninstall.go
+++ b/operator/cmd/cluster/uninstall.go
@@ -26,7 +26,7 @@ type uninstallArgs struct {
func addUninstallFlags(cmd *cobra.Command, args *uninstallArgs) {
cmd.PersistentFlags().StringVarP(&args.files, "filename", "f", "",
- "The filename of the IstioOperator CR.")
+ "The filename of the DubboOperator CR.")
cmd.PersistentFlags().StringArrayVarP(&args.sets, "set", "s", nil,
"Override dubboOperator values, such as selecting profiles, etc")
cmd.PersistentFlags().BoolVar(&args.purge, "purge", false, "Remove all
dubbo-related source code")
}
@@ -43,6 +43,9 @@ func UninstallCmd(ctx cli.Context) *cobra.Command {
# Uninstall all control planes and shared resources
dubboctl uninstall --purge`,
+ Args: func(cmd *cobra.Command, args []string) error {
+ return fmt.Errorf("at least one of the --filename or
--purge flags must be set")
+ },
RunE: func(cmd *cobra.Command, args []string) error {
return UnInstall(cmd, ctx, rootArgs, uiArgs)
},
diff --git a/operator/pkg/component/component.go
b/operator/pkg/component/component.go
index b31b24f0..73e56cac 100644
--- a/operator/pkg/component/component.go
+++ b/operator/pkg/component/component.go
@@ -36,7 +36,7 @@ var (
BaseComponentName: "Dubbo Core",
}
Icons = map[Name]string{
- BaseComponentName: "🚄",
+ BaseComponentName: "🎊",
}
)
