(dubbo) branch 3.3 updated: Removed mGroup from NamedThreadFactory (#15202)

[albumenj]

This is an automated email from the ASF dual-hosted git repository.

albumenj pushed a commit to branch 3.3
in repository https://gitbox.apache.org/repos/asf/dubbo.git


The following commit(s) were added to refs/heads/3.3 by this push:
     new ace86c94ca Removed mGroup from NamedThreadFactory (#15202)
ace86c94ca is described below

commit ace86c94ca257ab4d3298aefccd4f7d38edb9687
Author: zrlw <z...@sina.com>
AuthorDate: Tue Mar 4 09:51:06 2025 +0800

    Removed mGroup from NamedThreadFactory (#15202)
---
 .../dubbo/common/threadlocal/NamedInternalThreadFactory.java   |  2 +-
 .../java/org/apache/dubbo/common/utils/NamedThreadFactory.java | 10 +---------
 .../org/apache/dubbo/common/utils/NamedThreadFactoryTest.java  |  7 -------
 3 files changed, 2 insertions(+), 17 deletions(-)

diff --git 
a/dubbo-common/src/main/java/org/apache/dubbo/common/threadlocal/NamedInternalThreadFactory.java
 
b/dubbo-common/src/main/java/org/apache/dubbo/common/threadlocal/NamedInternalThreadFactory.java
index 7b7f14aae0..06e666f129 100644
--- 
a/dubbo-common/src/main/java/org/apache/dubbo/common/threadlocal/NamedInternalThreadFactory.java
+++ 
b/dubbo-common/src/main/java/org/apache/dubbo/common/threadlocal/NamedInternalThreadFactory.java
@@ -39,7 +39,7 @@ public class NamedInternalThreadFactory extends 
NamedThreadFactory {
     @Override
     public Thread newThread(Runnable runnable) {
         String name = mPrefix + mThreadNum.getAndIncrement();
-        InternalThread ret = new InternalThread(mGroup, 
InternalRunnable.Wrap(runnable), name, 0);
+        InternalThread ret = new 
InternalThread(InternalRunnable.Wrap(runnable), name);
         ret.setDaemon(mDaemon);
         return ret;
     }
diff --git 
a/dubbo-common/src/main/java/org/apache/dubbo/common/utils/NamedThreadFactory.java
 
b/dubbo-common/src/main/java/org/apache/dubbo/common/utils/NamedThreadFactory.java
index a7ea031a9b..433671b40b 100755
--- 
a/dubbo-common/src/main/java/org/apache/dubbo/common/utils/NamedThreadFactory.java
+++ 
b/dubbo-common/src/main/java/org/apache/dubbo/common/utils/NamedThreadFactory.java
@@ -32,8 +32,6 @@ public class NamedThreadFactory implements ThreadFactory {
 
     protected final boolean mDaemon;
 
-    protected final ThreadGroup mGroup;
-
     public NamedThreadFactory() {
         this("pool-" + POOL_SEQ.getAndIncrement(), false);
     }
@@ -45,22 +43,16 @@ public class NamedThreadFactory implements ThreadFactory {
     public NamedThreadFactory(String prefix, boolean daemon) {
         mPrefix = prefix + "-thread-";
         mDaemon = daemon;
-        SecurityManager s = System.getSecurityManager();
-        mGroup = (s == null) ? Thread.currentThread().getThreadGroup() : 
s.getThreadGroup();
     }
 
     @Override
     public Thread newThread(Runnable runnable) {
         String name = mPrefix + mThreadNum.getAndIncrement();
-        Thread ret = new Thread(mGroup, runnable, name, 0);
+        Thread ret = new Thread(runnable, name);
         ret.setDaemon(mDaemon);
         return ret;
     }
 
-    public ThreadGroup getThreadGroup() {
-        return mGroup;
-    }
-
     // for test
     public AtomicInteger getThreadNum() {
         return mThreadNum;
diff --git 
a/dubbo-common/src/test/java/org/apache/dubbo/common/utils/NamedThreadFactoryTest.java
 
b/dubbo-common/src/test/java/org/apache/dubbo/common/utils/NamedThreadFactoryTest.java
index 5498a333cc..2f36386134 100644
--- 
a/dubbo-common/src/test/java/org/apache/dubbo/common/utils/NamedThreadFactoryTest.java
+++ 
b/dubbo-common/src/test/java/org/apache/dubbo/common/utils/NamedThreadFactoryTest.java
@@ -59,11 +59,4 @@ class NamedThreadFactoryTest {
         assertNotNull(threadNum);
         assertEquals(INITIAL_THREAD_NUM, threadNum.get());
     }
-
-    @Test
-    public void testGetThreadGroup() {
-        NamedThreadFactory threadFactory = new NamedThreadFactory();
-        ThreadGroup threadGroup = threadFactory.getThreadGroup();
-        assertNotNull(threadGroup);
-    }
 }