This is an automated email from the ASF dual-hosted git repository.
alexstocks pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/dubbo-go.git
The following commit(s) were added to refs/heads/develop by this push:
new daeedf231 handle SonarQubeCould AI bot warning （#2895） (#2902)
daeedf231 is described below
commit daeedf231c2eb221cbb497ec0ad71c40c0f6eb09
Author: Sirui Huang <[email protected]>
AuthorDate: Fri May 30 22:30:29 2025 +0800
handle SonarQubeCould AI bot warning （#2895） (#2902)
* handle SonarQubeCould AI bot warning
* 和项目主分支非修改部分保持一致
* fix the problem about registry/nacos/service_discovery_test.go:123:39:
undefined: protocol (typecheck)
* fix the bug
* change protocol to base
---
cluster/loadbalance/aliasmethod/alias_method.go | 4 ++--
cluster/loadbalance/iwrr/iwrr.go | 2 +-
cluster/router/condition/route.go | 2 +-
metrics/util/aggregate/aggregator_test.go | 4 ++--
protocol/triple/triple_protocol/triple_ext_test.go | 4 ++--
5 files changed, 8 insertions(+), 8 deletions(-)
diff --git a/cluster/loadbalance/aliasmethod/alias_method.go
b/cluster/loadbalance/aliasmethod/alias_method.go
index 145548fff..dbbe93b06 100644
--- a/cluster/loadbalance/aliasmethod/alias_method.go
+++ b/cluster/loadbalance/aliasmethod/alias_method.go
@@ -107,8 +107,8 @@ func (am *aliasMethodPicker) init(invocation
base.Invocation) {
}
func (am *aliasMethodPicker) Pick() base.Invoker {
- i := rand.Intn(len(am.invokers))
- if rand.Float64() < am.prob[i] {
+ i := rand.Intn(len(am.invokers)) //NOSONAR
+ if rand.Float64() < am.prob[i] { //NOSONAR
return am.invokers[i]
}
return am.invokers[am.alias[i]]
diff --git a/cluster/loadbalance/iwrr/iwrr.go b/cluster/loadbalance/iwrr/iwrr.go
index f26397731..938e77db7 100644
--- a/cluster/loadbalance/iwrr/iwrr.go
+++ b/cluster/loadbalance/iwrr/iwrr.go
@@ -83,7 +83,7 @@ func NewInterleavedweightedRoundRobin(invokers
[]base.Invoker, invocation base.I
iwrrp.next = NewIwrrQueue()
size := uint64(len(invokers))
- offset := rand.Uint64() % size
+ offset := rand.Uint64() % size //NOSONAR
step := int64(0)
for idx := uint64(0); idx < size; idx++ {
invoker := invokers[(idx+offset)%size]
diff --git a/cluster/router/condition/route.go
b/cluster/router/condition/route.go
index 019a4c883..63e7e284f 100644
--- a/cluster/router/condition/route.go
+++ b/cluster/router/condition/route.go
@@ -372,7 +372,7 @@ func (s *destSets) randDest() *destination {
if len(s.destinations) == 1 {
return s.destinations[0]
}
- sum := rand.Intn(s.weightSum)
+ sum := rand.Intn(s.weightSum) //NOSONAR
for _, d := range s.destinations {
sum -= d.weight
if sum <= 0 {
diff --git a/metrics/util/aggregate/aggregator_test.go
b/metrics/util/aggregate/aggregator_test.go
index ab661dcfe..85f8ea498 100644
--- a/metrics/util/aggregate/aggregator_test.go
+++ b/metrics/util/aggregate/aggregator_test.go
@@ -64,7 +64,7 @@ func BenchmarkTimeWindowAggregatorAdd(b *testing.B) {
wg.Add(1)
go func() {
defer wg.Done()
- tw.Add(rand.Float64() * 100)
+ tw.Add(rand.Float64() * 100) //NOSONAR
}()
}
wg.Wait()
@@ -76,7 +76,7 @@ func BenchmarkTimeWindowAggregatorResult(b *testing.B) {
for i := 0; i < b.N; i++ {
wg.Add(1)
go func() {
- tw.Add(rand.Float64() * 100)
+ tw.Add(rand.Float64() * 100) //NOSONAR
}()
go func() {
defer wg.Done()
diff --git a/protocol/triple/triple_protocol/triple_ext_test.go
b/protocol/triple/triple_protocol/triple_ext_test.go
index 65613ba9f..cbee90e7d 100644
--- a/protocol/triple/triple_protocol/triple_ext_test.go
+++ b/protocol/triple/triple_protocol/triple_ext_test.go
@@ -33,7 +33,6 @@ import (
import (
"google.golang.org/protobuf/proto"
-
"google.golang.org/protobuf/reflect/protoregistry"
)
@@ -41,6 +40,7 @@ import (
triple "dubbo.apache.org/dubbo-go/v3/protocol/triple/triple_protocol"
"dubbo.apache.org/dubbo-go/v3/protocol/triple/triple_protocol/internal/assert"
"dubbo.apache.org/dubbo-go/v3/protocol/triple/triple_protocol/internal/gen/proto/connect/import/v1/importv1connect"
+
pingv1
"dubbo.apache.org/dubbo-go/v3/protocol/triple/triple_protocol/internal/gen/proto/connect/ping/v1"
"dubbo.apache.org/dubbo-go/v3/protocol/triple/triple_protocol/internal/gen/proto/connect/ping/v1/pingv1connect"
)
@@ -544,7 +544,7 @@ func TestConcurrentStreams(t *testing.T) {
assert.Nil(t, err)
start.Wait()
for i := 0; i < 100; i++ {
- num := rand.Int63n(1000) //nolint: gosec
+ num := rand.Int63n(1000) //nolint: gosec
//NOSONAR
total += num
if err :=
sum.Send(&pingv1.CumSumRequest{Number: num}); err != nil {
t.Errorf("failed to send request: %v",
err)
