This is an automated email from the ASF dual-hosted git repository.
zhongxjian pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/dubbo-kubernetes.git
The following commit(s) were added to refs/heads/master by this push:
new 5691c56c [chore] fix workflow v1
5691c56c is described below
commit 5691c56c472e598720353b9edb484998b590a167
Author: mfordjody <[email protected]>
AuthorDate: Sat May 31 17:42:13 2025 +0800
[chore] fix workflow v1
---
.github/workflows/dubboctl-release.yaml | 23 +++++++++--------------
Makefile | 1 -
2 files changed, 9 insertions(+), 15 deletions(-)
diff --git a/.github/workflows/dubboctl-release.yaml
b/.github/workflows/dubboctl-release.yaml
index 69547c3b..c6388af0 100644
--- a/.github/workflows/dubboctl-release.yaml
+++ b/.github/workflows/dubboctl-release.yaml
@@ -20,9 +20,6 @@
name: dubboctl Release
on:
- push:
- tags:
- - 'dubboctl/**'
release:
types: [published]
@@ -32,7 +29,6 @@ jobs:
permissions:
contents: write
runs-on: ubuntu-latest
- if: startsWith(github.event.release.tag_name, 'dubboctl/')
strategy:
matrix:
goos: [linux, darwin, windows]
@@ -40,7 +36,6 @@ jobs:
exclude:
- goos: darwin
goarch: 386
-
steps:
- name: Checkout code
uses: actions/checkout@v4
@@ -81,12 +76,12 @@ jobs:
echo "name=${FILENAME}.tar.gz" >> $GITHUB_OUTPUT
fi
-# - name: Upload release asset
-# uses: actions/upload-release-asset@v1
-# env:
-# GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
-# with:
-# upload_url: ${{ github.event.release.upload_url }}
-# asset_path: ./${{ steps.package.outputs.name }}
-# asset_name: ${{ steps.package.outputs.name }}
-# asset_content_type: application/zip
\ No newline at end of file
+ - name: Upload release asset
+ uses: actions/upload-release-asset@v1
+ env:
+ GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+ with:
+ upload_url: ${{ github.event.release.upload_url }}
+ asset_path: ./${{ steps.package.outputs.name }}
+ asset_name: ${{ steps.package.outputs.name }}
+ asset_content_type: application/zip
\ No newline at end of file
diff --git a/Makefile b/Makefile
index 292d3522..153b0bbe 100644
--- a/Makefile
+++ b/Makefile
@@ -17,7 +17,6 @@ SHELL := /usr/bin/env bash
.PHONY: build-dubboctl
build-dubboctl:
- mkdir -p bin
CGO_ENABLED=0 GOOS=$(GOOS) GOARCH=$(GOARCH) go build \
-ldflags "-X
github.com/apache/dubbo-kubernetes/pkg/version.gitTag=$(GIT_VERSION)" \
-o bin/dubboctl dubboctl/main.go
\ No newline at end of file
