This is an automated email from the ASF dual-hosted git repository.

zrlw pushed a commit to branch 3.3
in repository https://gitbox.apache.org/repos/asf/dubbo.git


The following commit(s) were added to refs/heads/3.3 by this push:
     new 48b23898ab Add listener to NacosMetadataReport casListenMap without 
serviceKey checking (#15476)
48b23898ab is described below

commit 48b23898ab5777172eb911275fe54c2438dc3ac8
Author: zrlw <[email protected]>
AuthorDate: Mon Jun 23 09:39:38 2025 +0800

    Add listener to NacosMetadataReport casListenMap without serviceKey 
checking (#15476)
---
 .../apache/dubbo/metadata/store/nacos/NacosMetadataReport.java   | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

diff --git 
a/dubbo-metadata/dubbo-metadata-report-nacos/src/main/java/org/apache/dubbo/metadata/store/nacos/NacosMetadataReport.java
 
b/dubbo-metadata/dubbo-metadata-report-nacos/src/main/java/org/apache/dubbo/metadata/store/nacos/NacosMetadataReport.java
index 621de18ece..cef5081f13 100644
--- 
a/dubbo-metadata/dubbo-metadata-report-nacos/src/main/java/org/apache/dubbo/metadata/store/nacos/NacosMetadataReport.java
+++ 
b/dubbo-metadata/dubbo-metadata-report-nacos/src/main/java/org/apache/dubbo/metadata/store/nacos/NacosMetadataReport.java
@@ -300,13 +300,16 @@ public class NacosMetadataReport extends 
AbstractMetadataReport {
         return new ConfigItem(content, casMd5);
     }
 
+    /**
+     * allow adding listener without checking if the serviceKey is existed in 
the map.
+     * there are multiple references which have the same serviceKey but might 
have multiple listeners,
+     * because the extra parameters of their subscribed URLs might be 
different.
+     */
     @Override
     public Set<String> getServiceAppMapping(String serviceKey, MappingListener 
listener, URL url) {
         String group = DEFAULT_MAPPING_GROUP;
 
-        if (null == casListenerMap.get(buildListenerKey(serviceKey, group))) {
-            addCasServiceMappingListener(serviceKey, group, listener);
-        }
+        addCasServiceMappingListener(serviceKey, group, listener);
         String content = getConfig(serviceKey, group);
         return ServiceNameMapping.getAppNames(content);
     }

Reply via email to