(dubbo-go) branch develop updated: fix(roundrobin): add lastUpdate field when storing weightedRoundRobin (#3053)

[alexstocks]

This is an automated email from the ASF dual-hosted git repository.

alexstocks pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/dubbo-go.git


The following commit(s) were added to refs/heads/develop by this push:
     new 8b90a278e fix(roundrobin): add lastUpdate field when storing 
weightedRoundRobin (#3053)
8b90a278e is described below

commit 8b90a278ee2e762fe43025a0845fad99469104d0
Author: Liu hongsen <54827140+hsd...@users.noreply.github.com>
AuthorDate: Sat Nov 1 09:42:11 2025 +0800

    fix(roundrobin): add lastUpdate field when storing weightedRoundRobin 
(#3053)
    
    * fix(roundrobin): add lastUpdate field when storing weightedRoundRobin
    
    ---------
    
    Co-authored-by: liuhongsen <liuhong...@ouryun.com.cn>
---
 cluster/loadbalance/roundrobin/loadbalance.go | 27 ++++++++++++++++++---------
 1 file changed, 18 insertions(+), 9 deletions(-)

diff --git a/cluster/loadbalance/roundrobin/loadbalance.go 
b/cluster/loadbalance/roundrobin/loadbalance.go
index c4dcab278..ce5284560 100644
--- a/cluster/loadbalance/roundrobin/loadbalance.go
+++ b/cluster/loadbalance/roundrobin/loadbalance.go
@@ -79,15 +79,17 @@ func (lb *rrLoadBalance) Select(invokers []base.Invoker, 
invocation base.Invocat
        )
 
        for _, invoker := range invokers {
-               weight := loadbalance.GetWeight(invoker, invocation)
-               if weight < 0 {
-                       weight = 0
-               }
+               weight := max(loadbalance.GetWeight(invoker, invocation), 0)
 
                identifier := invoker.GetURL().Key()
-               loaded, found := cachedInvokers.LoadOrStore(identifier, 
&weightedRoundRobin{weight: weight})
+               wr := &weightedRoundRobin{weight: weight}
+               wr.setLastUpdate(&now)
+               loaded, found := cachedInvokers.LoadOrStore(identifier, wr)
                weightRobin := loaded.(*weightedRoundRobin)
-               if !found {
+
+               if found {
+                       weightRobin.setLastUpdate(&now)
+               } else {
                        clean = true
                }
 
@@ -96,7 +98,6 @@ func (lb *rrLoadBalance) Select(invokers []base.Invoker, 
invocation base.Invocat
                }
 
                currentWeight := weightRobin.increaseCurrent()
-               weightRobin.lastUpdate = &now
 
                if currentWeight > maxCurrentWeight {
                        maxCurrentWeight = currentWeight
@@ -122,7 +123,7 @@ func cleanIfRequired(clean bool, invokers *cachedInvokers, 
now *time.Time) {
                defer atomic.CompareAndSwapInt32(&state, Updating, Complete)
                invokers.Range(func(identify, robin any) bool {
                        weightedRoundRobin := robin.(*weightedRoundRobin)
-                       elapsed := 
now.Sub(*weightedRoundRobin.lastUpdate).Nanoseconds()
+                       elapsed := 
now.Sub(*weightedRoundRobin.LastUpdate()).Nanoseconds()
                        if elapsed > recyclePeriod {
                                invokers.Delete(identify)
                        }
@@ -135,7 +136,7 @@ func cleanIfRequired(clean bool, invokers *cachedInvokers, 
now *time.Time) {
 type weightedRoundRobin struct {
        weight     int64
        current    int64
-       lastUpdate *time.Time
+       lastUpdate atomic.Pointer[time.Time]
 }
 
 func (robin *weightedRoundRobin) Weight() int64 {
@@ -147,6 +148,14 @@ func (robin *weightedRoundRobin) setWeight(weight int64) {
        robin.current = 0
 }
 
+func (robin *weightedRoundRobin) LastUpdate() *time.Time {
+       return robin.lastUpdate.Load()
+}
+
+func (robin *weightedRoundRobin) setLastUpdate(time *time.Time) {
+       robin.lastUpdate.Store(time)
+}
+
 func (robin *weightedRoundRobin) increaseCurrent() int64 {
        return atomic.AddInt64(&robin.current, robin.weight)
 }