This is an automated email from the ASF dual-hosted git repository.
alexstocks pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/dubbo-go-samples.git
The following commit(s) were added to refs/heads/main by this push:
new 47fbdf09 feat: upgrade dubbo-go to v3.3.1 and fix panic problems in
registry files (#1013)
47fbdf09 is described below
commit 47fbdf098f715baa9a80d16579b08724e1f79d9a
Author: 陈乐樂 <[email protected]>
AuthorDate: Tue Jan 6 19:27:36 2026 +0800
feat: upgrade dubbo-go to v3.3.1 and fix panic problems in registry files
(#1013)
* feat: upgrade dubbo-go to v3.3.1 and fix panic problems in registy files
---
registry/etcd/go-client/client.go | 3 +++
registry/etcd/go-server/server.go | 6 +++++-
registry/nacos/go-client/cmd/client.go | 3 +++
registry/nacos/go-server/cmd/server.go | 15 +++++++++++++--
registry/zookeeper/go-client/cmd/client.go | 3 +++
registry/zookeeper/go-server/cmd/server.go | 6 +++++-
6 files changed, 32 insertions(+), 4 deletions(-)
diff --git a/registry/etcd/go-client/client.go
b/registry/etcd/go-client/client.go
index c07f2a3d..08ed9b9c 100644
--- a/registry/etcd/go-client/client.go
+++ b/registry/etcd/go-client/client.go
@@ -44,16 +44,19 @@ func main() {
),
)
if err != nil {
+ logger.Errorf("new dubbo instance failed: %v", err)
panic(err)
}
// configure the params that only client layer cares
cli, err := ins.NewClient()
if err != nil {
+ logger.Errorf("new client failed: %v", err)
panic(err)
}
svc, err := greet.NewGreetService(cli)
if err != nil {
+ logger.Errorf("create greet service failed: %v", err)
panic(err)
}
diff --git a/registry/etcd/go-server/server.go
b/registry/etcd/go-server/server.go
index 46b4f0a7..46aa2afa 100644
--- a/registry/etcd/go-server/server.go
+++ b/registry/etcd/go-server/server.go
@@ -55,17 +55,21 @@ func main() {
),
)
if err != nil {
+ logger.Errorf("new dubbo instance failed: %v", err)
panic(err)
}
srv, err := ins.NewServer()
if err != nil {
+ logger.Errorf("new server failed: %v", err)
panic(err)
}
if err := greet.RegisterGreetServiceHandler(srv, &GreetTripleServer{});
err != nil {
+ logger.Errorf("register greet handler failed: %v", err)
panic(err)
}
if err := srv.Serve(); err != nil {
- logger.Error(err)
+ logger.Errorf("server serve failed: %v", err)
+ panic(err)
}
}
diff --git a/registry/nacos/go-client/cmd/client.go
b/registry/nacos/go-client/cmd/client.go
index 2e5b1fe8..676a39d1 100644
--- a/registry/nacos/go-client/cmd/client.go
+++ b/registry/nacos/go-client/cmd/client.go
@@ -44,16 +44,19 @@ func main() {
),
)
if err != nil {
+ logger.Errorf("new dubbo instance failed: %v", err)
panic(err)
}
// configure the params that only client layer cares
cli, err := ins.NewClient()
if err != nil {
+ logger.Errorf("new client failed: %v", err)
panic(err)
}
svc, err := greet.NewGreetService(cli)
if err != nil {
+ logger.Errorf("create greet service failed: %v", err)
panic(err)
}
diff --git a/registry/nacos/go-server/cmd/server.go
b/registry/nacos/go-server/cmd/server.go
index f1e31019..ff7ad36a 100644
--- a/registry/nacos/go-server/cmd/server.go
+++ b/registry/nacos/go-server/cmd/server.go
@@ -19,6 +19,7 @@ package main
import (
"context"
+ "strings"
)
import (
@@ -43,11 +44,14 @@ func (srv *GreetTripleServer) Greet(ctx context.Context,
req *greet.GreetRequest
}
func main() {
+ nacosAddr := "127.0.0.1:8848"
+ nacosGrpcPort := "9848"
+
ins, err := dubbo.NewInstance(
dubbo.WithName("dubbo_registry_nacos_server"),
dubbo.WithRegistry(
registry.WithNacos(),
- registry.WithAddress("127.0.0.1:8848"),
+ registry.WithAddress(nacosAddr),
),
dubbo.WithProtocol(
protocol.WithTriple(),
@@ -55,17 +59,24 @@ func main() {
),
)
if err != nil {
+ logger.Errorf("new dubbo instance failed: %v", err)
panic(err)
}
srv, err := ins.NewServer()
if err != nil {
+ logger.Errorf("new server failed: %v", err)
panic(err)
}
if err := greet.RegisterGreetServiceHandler(srv, &GreetTripleServer{});
err != nil {
+ logger.Errorf("register greet handler failed: %v", err)
panic(err)
}
if err := srv.Serve(); err != nil {
- logger.Error(err)
+ logger.Errorf("server serve failed: %v", err)
+ if strings.Contains(err.Error(), "client not connected") {
+ logger.Errorf("hint: Nacos client not connected (gRPC).
Check %s is reachable and gRPC port %s is open (Nacos 2.x default).",
nacosAddr, nacosGrpcPort)
+ }
+ panic(err)
}
}
diff --git a/registry/zookeeper/go-client/cmd/client.go
b/registry/zookeeper/go-client/cmd/client.go
index 79fe9be7..36b31f1a 100644
--- a/registry/zookeeper/go-client/cmd/client.go
+++ b/registry/zookeeper/go-client/cmd/client.go
@@ -44,16 +44,19 @@ func main() {
),
)
if err != nil {
+ logger.Errorf("new dubbo instance failed: %v", err)
panic(err)
}
// configure the params that only client layer cares
cli, err := ins.NewClient()
if err != nil {
+ logger.Errorf("new client failed: %v", err)
panic(err)
}
svc, err := greet.NewGreetService(cli)
if err != nil {
+ logger.Errorf("create greet service failed: %v", err)
panic(err)
}
diff --git a/registry/zookeeper/go-server/cmd/server.go
b/registry/zookeeper/go-server/cmd/server.go
index 59a5ea13..e2958d0a 100644
--- a/registry/zookeeper/go-server/cmd/server.go
+++ b/registry/zookeeper/go-server/cmd/server.go
@@ -55,19 +55,23 @@ func main() {
),
)
if err != nil {
+ logger.Errorf("new dubbo instance failed: %v", err)
panic(err)
}
srv, err := ins.NewServer()
if err != nil {
+ logger.Errorf("new server failed: %v", err)
panic(err)
}
if err := greet.RegisterGreetServiceHandler(srv, &GreetTripleServer{});
err != nil {
+ logger.Errorf("register greet handler failed: %v", err)
panic(err)
}
if err := srv.Serve(); err != nil {
- logger.Error(err)
+ logger.Errorf("server serve failed: %v", err)
+ panic(err)
}
}
