This is an automated email from the ASF dual-hosted git repository.
mfordjody pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/dubbo-kubernetes.git
The following commit(s) were added to refs/heads/master by this push:
new 54d42ecc Require maintainer approval on master (#970)
54d42ecc is described below
commit 54d42eccf1fae43d20f4f0ed188cd0a2d28d0b4d
Author: mfordjody <[email protected]>
AuthorDate: Mon Jul 20 02:53:44 2026 +0800
Require maintainer approval on master (#970)
* Require maintainer approval on master
* Disambiguate maintainer approval status
---
.asf.yaml | 10 +++++++---
.github/workflows/commands.yml | 2 +-
.github/workflows/review-gate.yml | 4 ++--
3 files changed, 10 insertions(+), 6 deletions(-)
diff --git a/.asf.yaml b/.asf.yaml
index 4b54410a..32f23cb0 100644
--- a/.asf.yaml
+++ b/.asf.yaml
@@ -39,6 +39,10 @@ github:
master:
required_status_checks:
strict: true
- contexts:
- # This stable aggregate check fails unless every required CI job
passes.
- - CI Required
+ checks:
+ # Pin both gates to the GitHub Actions App so a personal token cannot
+ # forge either required result.
+ - context: CI Required
+ app_id: 15368
+ - context: Maintainer Approval Gate
+ app_id: 15368
diff --git a/.github/workflows/commands.yml b/.github/workflows/commands.yml
index a0cdfbe6..15024dd3 100644
--- a/.github/workflows/commands.yml
+++ b/.github/workflows/commands.yml
@@ -94,7 +94,7 @@ jobs:
repo,
sha: pr.head.sha,
state: match[1] && !authorIsMaintainer ? 'pending' : 'success',
- context: 'Maintainer Approval',
+ context: 'Maintainer Approval Gate',
description: match[1] && !authorIsMaintainer
? 'Maintainer approval cancelled'
: 'Approved by @mfordjody via /lgtm',
diff --git a/.github/workflows/review-gate.yml
b/.github/workflows/review-gate.yml
index 196aa218..33716b9f 100644
--- a/.github/workflows/review-gate.yml
+++ b/.github/workflows/review-gate.yml
@@ -43,7 +43,7 @@ permissions:
jobs:
approval:
- name: Maintainer Approval
+ name: Publish Maintainer Approval
runs-on: ubuntu-latest
timeout-minutes: 5
if: |
@@ -63,7 +63,7 @@ jobs:
repo,
sha,
state,
- context: 'Maintainer Approval',
+ context: 'Maintainer Approval Gate',
description,
target_url: targetUrl,
});