This is an automated email from the ASF dual-hosted git repository.
mfordjody pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/dubbo-kubernetes.git
The following commit(s) were added to refs/heads/master by this push:
new 0b02ec98 Fix maintainer review detection (#971)
0b02ec98 is described below
commit 0b02ec98b6d29f6d762cd1e7f720e6eb8265518b
Author: mfordjody <[email protected]>
AuthorDate: Mon Jul 20 03:07:51 2026 +0800
Fix maintainer review detection (#971)
---
.github/workflows/review-gate.yml | 10 ++++++----
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/.github/workflows/review-gate.yml
b/.github/workflows/review-gate.yml
index 33716b9f..be8f2885 100644
--- a/.github/workflows/review-gate.yml
+++ b/.github/workflows/review-gate.yml
@@ -92,17 +92,19 @@ jobs:
const authorIsMaintainer = pr.user.login.toLowerCase() ===
maintainer;
let approved = authorIsMaintainer;
if (!approved) {
- const reviews = await
github.paginate(github.rest.pulls.listReviews, {
+ const reviews = await github.paginate('GET
/repos/{owner}/{repo}/pulls/{pull_number}/reviews', {
owner,
repo,
pull_number: pr.number,
per_page: 100,
});
- approved = reviews.some((review) =>
- review.user?.login.toLowerCase() === maintainer &&
- review.state === 'APPROVED' &&
+ const currentApprovals = reviews.filter((review) =>
+ review.user?.login?.toLowerCase() === maintainer &&
+ String(review.state).toUpperCase() === 'APPROVED' &&
review.commit_id === pr.head.sha,
);
+ core.info(`Found ${currentApprovals.length} current approval(s)
from @${maintainer} among ${reviews.length} review(s)`);
+ approved = currentApprovals.length > 0;
}
await publish(
