Repository: incubator-eagle Updated Branches: refs/heads/master fa4334e1e -> 9954b4e11
EAGLE-713: Publish & Router bolts spec change is not thread safe Author: Li, Garrett Reviewer: ralphsu This closes #590 Project: http://git-wip-us.apache.org/repos/asf/incubator-eagle/repo Commit: http://git-wip-us.apache.org/repos/asf/incubator-eagle/commit/9954b4e1 Tree: http://git-wip-us.apache.org/repos/asf/incubator-eagle/tree/9954b4e1 Diff: http://git-wip-us.apache.org/repos/asf/incubator-eagle/diff/9954b4e1 Branch: refs/heads/master Commit: 9954b4e1187bbcd8f4b4961b9ca4fa1d06c99cbb Parents: fa4334e Author: Xiancheng Li <xiancheng...@ebay.com> Authored: Tue Nov 1 10:55:28 2016 +0800 Committer: Ralph, Su <suliang...@gmail.com> Committed: Tue Nov 1 12:26:27 2016 +0800 ---------------------------------------------------------------------- .../org/apache/eagle/alert/engine/runner/AlertPublisherBolt.java | 2 +- .../org/apache/eagle/alert/engine/runner/StreamRouterBolt.java | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/incubator-eagle/blob/9954b4e1/eagle-core/eagle-alert-parent/eagle-alert/alert-engine/src/main/java/org/apache/eagle/alert/engine/runner/AlertPublisherBolt.java ---------------------------------------------------------------------- diff --git a/eagle-core/eagle-alert-parent/eagle-alert/alert-engine/src/main/java/org/apache/eagle/alert/engine/runner/AlertPublisherBolt.java b/eagle-core/eagle-alert-parent/eagle-alert/alert-engine/src/main/java/org/apache/eagle/alert/engine/runner/AlertPublisherBolt.java index 95f2a8f..2fe5671 100644 --- a/eagle-core/eagle-alert-parent/eagle-alert/alert-engine/src/main/java/org/apache/eagle/alert/engine/runner/AlertPublisherBolt.java +++ b/eagle-core/eagle-alert-parent/eagle-alert/alert-engine/src/main/java/org/apache/eagle/alert/engine/runner/AlertPublisherBolt.java @@ -91,7 +91,7 @@ public class AlertPublisherBolt extends AbstractStreamBolt implements AlertPubli } @Override - public void onAlertPublishSpecChange(PublishSpec pubSpec, Map<String, StreamDefinition> sds) { + public synchronized void onAlertPublishSpecChange(PublishSpec pubSpec, Map<String, StreamDefinition> sds) { if (pubSpec == null) { return; } http://git-wip-us.apache.org/repos/asf/incubator-eagle/blob/9954b4e1/eagle-core/eagle-alert-parent/eagle-alert/alert-engine/src/main/java/org/apache/eagle/alert/engine/runner/StreamRouterBolt.java ---------------------------------------------------------------------- diff --git a/eagle-core/eagle-alert-parent/eagle-alert/alert-engine/src/main/java/org/apache/eagle/alert/engine/runner/StreamRouterBolt.java b/eagle-core/eagle-alert-parent/eagle-alert/alert-engine/src/main/java/org/apache/eagle/alert/engine/runner/StreamRouterBolt.java index 1236b7f..6c39189 100644 --- a/eagle-core/eagle-alert-parent/eagle-alert/alert-engine/src/main/java/org/apache/eagle/alert/engine/runner/StreamRouterBolt.java +++ b/eagle-core/eagle-alert-parent/eagle-alert/alert-engine/src/main/java/org/apache/eagle/alert/engine/runner/StreamRouterBolt.java @@ -100,7 +100,7 @@ public class StreamRouterBolt extends AbstractStreamBolt implements StreamRouter */ @SuppressWarnings("unchecked") @Override - public void onStreamRouteBoltSpecChange(RouterSpec spec, Map<String, StreamDefinition> sds) { + public synchronized void onStreamRouteBoltSpecChange(RouterSpec spec, Map<String, StreamDefinition> sds) { sanityCheck(spec); // figure out added, removed, modified StreamSortSpec
