This is an automated email from the ASF dual-hosted git repository.

ovilia pushed a commit to branch fix-toolbox-html
in repository https://gitbox.apache.org/repos/asf/incubator-echarts.git

commit 85ff79d300d10772be26e76bedb81ee03f58da7d
Author: Ovilia <zwl.s...@gmail.com>
AuthorDate: Thu Apr 11 15:51:09 2019 +0800

    fix: set default position to be bottom
---
 src/component/toolbox/ToolboxView.js | 3 ++-
 test/toolbox-tooltip.html            | 2 +-
 2 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/src/component/toolbox/ToolboxView.js 
b/src/component/toolbox/ToolboxView.js
index 43c12c9..ad89108 100644
--- a/src/component/toolbox/ToolboxView.js
+++ b/src/component/toolbox/ToolboxView.js
@@ -170,7 +170,8 @@ export default echarts.extendComponentView({
                             name: iconName,
                             title: titles[iconName],
                             $vars: ['name', 'title']
-                        }
+                        },
+                        position: tooltipModel.get('position', true) || 
'bottom'
                     }, tooltipModel.option));
                 }
 
diff --git a/test/toolbox-tooltip.html b/test/toolbox-tooltip.html
index 6abd4a5..759bd5a 100644
--- a/test/toolbox-tooltip.html
+++ b/test/toolbox-tooltip.html
@@ -82,7 +82,7 @@ under the License.
                     tooltip: {
                         show: true,
                         formatter: function (param) {
-                            return param.title;
+                            return '<div>' + param.title + '</div><div 
class="triangle"></div>';
                         },
                         backgroundColor: '#222',
                         textStyle: {


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org

Reply via email to