100pah commented on a change in pull request #11373: fix(gauge): update data
with dataset #10945
URL:
https://github.com/apache/incubator-echarts/pull/11373#discussion_r334391229
##########
File path: src/chart/gauge/GaugeSeries.js
##########
@@ -26,8 +26,8 @@ var GaugeSeries = SeriesModel.extend({
type: 'series.gauge',
getInitialData: function (option, ecModel) {
- var dataOpt = option.data || [];
- if (!zrUtil.isArray(dataOpt)) {
+ var dataOpt = option.data;
+ if (dataOpt && !zrUtil.isArray(dataOpt)) {
dataOpt = [dataOpt];
Review comment:
This feature (convert value to array) seems not work since 4.x.
Do we need to remove it?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
