100pah opened a new pull request #12050: fix: enable `dispatchAction` highlight downplay for treemap. fix #9816. URL: https://github.com/apache/incubator-echarts/pull/12050 <!-- Please fill in the following information to help us review your PR more efficiently. --> ## Brief Information This pull request is in the type of: - [x] bug fixing - [ ] new feature - [ ] others ### What does this PR do? fix: enable `dispatchAction` highlight downplay for treemap. ### Fixed issues fix #9816. ## Details ### Before: What was the problem? Can not `dispatchAction` highlight downplay for treemap. ### After: How is it fixed in this PR? Enabled. ### Related test cases or examples to use the new APIs `test/treemap-disk2.html` ## Others ### Remain issue Whether highlight/downplay will effect all the subtree or only the hovered node? There are both scenarios, depending on the styles the treemap used. For example, a treemap uses border to distinguish the highlighted subtree, we should only highlight the target node rather than the entire subtree. Otherwise the all of the border inner the subtree will be highlighted unexpectedly. If a treemap uses area color to distinguish the highlighted subtree, the entire subtree needed to be highlighted. But I only support "highlight single node" here. Because based on the current mechanism, implement "highlight entire subtree" need some more code, a little like `focusNodeAdjacency` in `graph series`, and event more complicated because the zrender elements in treemap are nested so we need to consider a mouse over listener should/should not listen to its descendent.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
