100pah commented on a change in pull request #12147: Fix: minOpen is true will
drop a piece
URL:
https://github.com/apache/incubator-echarts/pull/12147#discussion_r379892312
##########
File path: src/component/visualMap/PiecewiseModel.js
##########
@@ -402,7 +402,7 @@ var resetMethods = {
if (thisOption.minOpen) {
pieceList.push({
- index: index++,
+ index: index,
Review comment:
Only remove `++` is not correct. Because after `++` removed, the first piece
and the second piece has the same `index`.
That cause when click on the first piece, both the first piece and the
second pieces are highlighted/downplayed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org
