Ovilia opened a new pull request #12243: fix(pie): label not show when animation is disabled. fix #12110 URL: https://github.com/apache/incubator-echarts/pull/12243 <!-- Please fill in the following information to help us review your PR more efficiently. --> ## Brief Information This pull request is in the type of: - [x] bug fixing - [ ] new feature - [ ] others ### What does this PR do? <!-- USE ONCE SENTENCE TO DESCRIBE WHAT THIS PR DOES. --> Hover style is not used if pie animation is set to be false. ### Fixed issues - #12110: label not show when animation is disabled ## Details ### Before: What was the problem? Test `test/pie-animation.html`. Label is not shown when hover on the pie. <!-- ADD SCREENSHOT HERE IF APPLICABLE. --> ### After: How is it fixed in this PR? ``` labelLine.ignore = labelLine.hoverIgnore; labelText.ignore = labelText.hoverIgnore; ``` `labelLine.ignore` and `labelText.ignore` should be changed into `hoverIgnore`, even if without animation. Note that a user may set `animation` to be true while `hoverAnimation` to be false for a pie chart to have the transition animation at initiation. So checking both `itemModel.get('hoverAnimation') && seriesModel.isAnimationEnabled()` in https://github.com/apache/incubator-echarts/commit/9847233b23a4d5bf65b01ebfb7d5547edb0e11cb#diff-19529e7aaddb5ad8b1b45417c96c8e00R184 does not update the animation states for transition animation. <!-- ADD SCREENSHOT HERE IF APPLICABLE. --> ## Usage ### Are there any API changes? - [ ] The API has been changed. <!-- LIST THE API CHANGES HERE --> ### Related test cases or examples to use the new APIs `test/pie-animation.html` and a visual test about it. ## Others ### Merging options - [x] Please squash the commits into a single one when merge. ### Other information
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
