quillblue opened a new pull request #12556: URL: https://github.com/apache/incubator-echarts/pull/12556
<!-- Please fill in the following information to help us review your PR more efficiently. --> ## Brief Information This pull request is in the type of: - [X] bug fixing - [ ] new feature - [ ] others ### What does this PR do? Update function of calculating updated height & width for rotated axis labels Fix issue #12259 ### Fixed issues Fix issue #12259 ## Details In previous `rotateTextRect()` in axisHelper.js, take cos value of negative rotate will got negative result, which causes calculated width/height of rotated axis label is smaller than actual size. In grid, it will cause axis labels be cut. ### After: How is it fixed in this PR? As physically we need cos/sin of rotate angle to be positive (or 0), add Math.abs here to solve this issue, ## Usage ### Are there any API changes? - [ ] The API has been changed. <!-- LIST THE API CHANGES HERE --> ### Related test cases or examples to use the new APIs NA. ## Others ### Merging options - [ ] Please squash the commits into a single one when merge. ### Other information ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
