plainheart opened a new pull request #12762: URL: https://github.com/apache/incubator-echarts/pull/12762
<!-- Please fill in the following information to help us review your PR more efficiently. --> ## Brief Information This pull request is in the type of: - [x] bug fixing - [ ] new feature - [ ] others ### What does this PR do? Because of the change about the structure of normal style and emphasis style, original logic about fetching formatter of label has been not suitable. There are some changes to be done. **Original way to fetch label formatter:** _normal_: `label.formatter` (It's okay now) _emphasis_: `label.emphasis.formatter`(in #10666, a dot is also missing, but even if we add it, it is still not correct for present option structure). **Present way to fetch label formatter:** _normal_: `label.formatter` (same as original way) _emphasis_: `emphasis.label.formatter` (See [`geo.emphasis.label.formatter`](https://echarts.apache.org/en/option.html#geo.emphasis.label.formatter)). ### Fixed issues - #10666 - #8612 ## Details ### Before: What was the problem? `geo.label.formatter` is not working. ### After: How is it fixed in this PR? Using the way suitable for current option structure. ```js var formatter = regionModel.get((status === 'normal' ? '' : 'emphasis.') + 'label.formatter'); ```  ## Usage ### Are there any API changes? - [x] The API has been changed. ### Related test cases or examples to use the new APIs Please refer to `test/geo-labelFormatter.html`. ## Others ### Merging options - [x] Please squash the commits into a single one when merge. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
