100pah commented on a change in pull request #12947:
URL:
https://github.com/apache/incubator-echarts/pull/12947#discussion_r458078752
##########
File path: src/util/format.ts
##########
@@ -66,6 +66,13 @@ export function encodeHTML(source: string): string {
});
}
+export function concatTooltipHtml(html: string, value: unknown, dontEncodeHtml
= false): string {
Review comment:
In my opinion, do not use language feature of "default parameters",
especially for a "public" util method.
echarts code trade those three things the same:
`null`, `undefined` and "no that parameter / no that property".
I think it's not a good practice to distinguish them and not necessary.
But the language feature of "default parameters" only works for undefined
and no parameter, but not for null.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
