pissang commented on a change in pull request #14214:
URL: https://github.com/apache/echarts/pull/14214#discussion_r571429458
##########
File path: src/label/labelStyle.ts
##########
@@ -421,6 +421,11 @@ function setTextStyleCommon(
if (margin != null) {
textStyle.margin = margin;
}
+ const ellipsis = textStyleModel.get('ellipsis');
+ if (ellipsis) {
+ textStyle.ellipsis = ellipsis;
+ }
+ textStyle.lineOverflow = textStyleModel.get('lineOverflow') || 'truncate';
Review comment:
In this way, developers still can't disable it by setting the option to
null. We should avoid applying default value in the code. Instead, default
value is better to be managed in the `defaultOption`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
