susiwen8 commented on a change in pull request #14569:
URL: https://github.com/apache/echarts/pull/14569#discussion_r605383031
##########
File path: src/coord/cartesian/Cartesian2D.ts
##########
@@ -146,15 +146,15 @@ class Cartesian2D extends Cartesian<Axis2D> implements
CoordinateSystem {
return out;
}
- pointToData(point: number[], out?: number[]): number[] {
+ pointToData(point: number[], out?: number[], reserved?: number[], clamp?:
boolean): number[] {
Review comment:
@pissang But, in base class
[`CoordinateSystem`](https://github.com/apache/echarts/blob/master/src/coord/CoordinateSystem.ts#L133),
the params for `pointToData` are ` point: number[], reserved?: any, out?:
number[]`, I have tried rearrange to ` point: number[], out?: number[],
reserved?: any`, but that would break type.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
